feat: Add Guide menu to on-screen virtual controller
#1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to allow the `Guide Button` to be pressed without a physical gamepad, add the button to the On-screen virtual controller
With the addition of the `guide menu` to the on screen virtual controller. A configuration to allow hiding it is not present
|
I am really looking forward to it as it will be a game changer for those using the app to connect to Batocera OS where the button acts like hotkey for several functionality. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some games/applications the
guide menu(or Xbox button) is actually important, for example when usingSteam Big Picturethis button opens the big picture's menu to tweak controller,exit game, etc...This PR adds to the On-screen virtual controller the
Guide Menu(The name can be changed) between theSTARTandBACKbuttons.It also adds a configuration for the ones that want to hide it and don't need to use it.
Motivation
Personally this helps me 100% as my second generic gamepad does not have this button and I have other combos mapped to
BACK + START.I would even add a configuration to only have this button, but I think maybe the PR #1247 already address it in a good way.Tested with both #1247 and #1171 and works perfectly, no conflicts and made my experience better
Screenshot