Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link cleanup #922

Merged
merged 5 commits into from May 14, 2024
Merged

link cleanup #922

merged 5 commits into from May 14, 2024

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented May 10, 2024

Description

I ended up updating and merging a bulk change to the links, but wasn't very smart about it. I didn't account for a lot of the little nuances and then I tried to backtrack to account for them, and I feel like I didn't catch all of the updates. So this PR is just to wipe the slate clean and start over with a more accurate approach that I feel way more confident with.

👉 The first commit finds all links that end in a backslash and removes the backslash
👉 The second commit runs a script that updates all internal links that do not reference images or sections and adds a backslash to those links
👉 The third and fourth commit cleans up internal links so they don't include https://docs.moonbeam.network (as they shouldn't for internal links) and updates all references to the docs site URL that are not actually links (i.e., in disclaimers, etc.)

Associated mkdocs PR that includes the script: papermoonio/moonbeam-mkdocs#187

Checklist

  • I have added a label to this PR 🏷️

@eshaben eshaben changed the title Eshaben/link reset link cleanup May 10, 2024
@eshaben eshaben added the A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.) label May 10, 2024
albertov19
albertov19 previously approved these changes May 10, 2024
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eshaben eshaben merged commit f3682ac into master May 14, 2024
1 check passed
@eshaben eshaben deleted the eshaben/link-reset branch May 14, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A2 - Maintenance Minor Pull request contains minor updates to an existing page (i.e., modifying parameters, steps, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants