New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes related to polkadot-sdk v.1.7.2 and XCM v4 #912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - @themacexpert please can you confirm that the tutorials are working?
@eshaben did you try the updated tutorials?
I went through each of the code snippets and made sure that all of the examples were properly formatted and generated the correct encoded calldata. I did not go through the tutorials from top to bottom. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@themacexpert thanks so much for checking these and switching to terminal snippets!!!
.snippets/code/tutorials/interoperability/uniswapv2-swap/generate-moonbeam-encoded-calldata.js
Outdated
Show resolved
Hide resolved
.snippets/code/tutorials/interoperability/uniswapv2-swap/generate-moonbeam-encoded-calldata.js
Outdated
Show resolved
Hide resolved
...ppets/code/tutorials/interoperability/remote-batched-evm-calls/terminal/build-xcm-message.md
Show resolved
Hide resolved
.snippets/code/tutorials/interoperability/remote-batched-evm-calls/terminal/encoded.md
Show resolved
Hide resolved
.snippets/code/tutorials/interoperability/remote-batched-evm-calls/terminal/send.md
Show resolved
Hide resolved
.snippets/code/tutorials/interoperability/uniswapv2-swap/terminal/build-message.md
Show resolved
Hide resolved
.snippets/code/tutorials/interoperability/uniswapv2-swap/terminal/encoded.md
Show resolved
Hide resolved
.snippets/code/tutorials/interoperability/uniswapv2-swap/terminal/send-xcm.md
Show resolved
Hide resolved
Updated the alphanet weights for the x-tokens pages. I'll do a separate PR to update polkadot and kusama |
… into eshaben/2900-polkadot-sdk-v1.7.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried out snippets with the new weights, working well!
Just found a few broken links is all. I think with the EIP-20 link there are multiple instances of that on the docs site so would be great to get them all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 59 parachain-embedded-specs link is broken
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 402 https://eips.ethereum.org/EIPS/eip-20/ Link is broken
@themacexpert it's related to the changes that just went through with the links. I just did a hard reset on all the links so these should be fixed in #922 and once that PR gets published, I'll run a scan to make sure that I clean up and remaining links that result in 404s |
Description
This PR updates the docs for the changes made to support the polkadot-sdk v.1.7.2 release, which includes XCM v4. I also took time to update the MRL docs and do a general cleanup of snippets.
Important things to note:
multi
prefix, so multilocation > location, multiasset > asset✍️ I have not changed our widespread use of multilocation to location
Checklist
moonbeam-docs-cn
repo, I have created a ticket for the translations in JiraAfter Translation Requirements
moonbeam-docs
repo to remove imagesmoonbeam-docs
repo to remove variablesmoonbeam-mkdocs
repo to add redirects for Chinese siteItems to be Updated
Please list any of the items that will need to be added or deleted after the translations are done here.