Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes related to polkadot-sdk v.1.7.2 and XCM v4 #912

Merged
merged 14 commits into from May 10, 2024

Conversation

eshaben
Copy link
Contributor

@eshaben eshaben commented Apr 26, 2024

Description

This PR updates the docs for the changes made to support the polkadot-sdk v.1.7.2 release, which includes XCM v4. I also took time to update the MRL docs and do a general cleanup of snippets.

Important things to note:

  • With XCM v4, concrete/abstract has been removed
  • With X1 junctions, you have to wrap the value in an array
  • There were some internal name changes that drop the multi prefix, so multilocation > location, multiasset > asset

✍️ I have not changed our widespread use of multilocation to location

⚠️ I deleted some old snippets and updated the names of others for consistency. This will break the examples on the Chinese docs site.

Checklist

  • I have added a label to this PR 🏷️
  • I have run my changes through Grammarly
  • If this requires translations for the moonbeam-docs-cn repo, I have created a ticket for the translations in Jira

After Translation Requirements

  • Will need to create PR in moonbeam-docs repo to remove images
  • Will need to create PR in moonbeam-docs repo to remove variables
  • Will need to create PR in moonbeam-mkdocs repo to add redirects for Chinese site
  • No additional PRs are required after the translations are done

Items to be Updated

Please list any of the items that will need to be added or deleted after the translations are done here.

@eshaben eshaben added the A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.) label Apr 26, 2024
albertov19
albertov19 previously approved these changes Apr 29, 2024
Copy link
Contributor

@albertov19 albertov19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @themacexpert please can you confirm that the tutorials are working?

@eshaben did you try the updated tutorials?

@eshaben
Copy link
Contributor Author

eshaben commented Apr 29, 2024

I went through each of the code snippets and made sure that all of the examples were properly formatted and generated the correct encoded calldata. I did not go through the tutorials from top to bottom.

Copy link
Contributor Author

@eshaben eshaben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@themacexpert thanks so much for checking these and switching to terminal snippets!!!

@eshaben
Copy link
Contributor Author

eshaben commented May 3, 2024

Updated the alphanet weights for the x-tokens pages. I'll do a separate PR to update polkadot and kusama

@eshaben eshaben requested a review from albertov19 May 3, 2024 21:54
Copy link
Contributor

@themacexpert themacexpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried out snippets with the new weights, working well!
Just found a few broken links is all. I think with the EIP-20 link there are multiple instances of that on the docs site so would be great to get them all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 59 parachain-embedded-specs link is broken

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 402 https://eips.ethereum.org/EIPS/eip-20/ Link is broken

@eshaben
Copy link
Contributor Author

eshaben commented May 10, 2024

@themacexpert it's related to the changes that just went through with the links. I just did a hard reset on all the links so these should be fixed in #922 and once that PR gets published, I'll run a scan to make sure that I clean up and remaining links that result in 404s

@eshaben eshaben merged commit 733a267 into master May 10, 2024
1 check passed
@eshaben eshaben deleted the eshaben/2900-polkadot-sdk-v1.7.2 branch May 10, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A1 - Maintenance Major Pull request contains major updates to an existing page (i.e., adding a new section, reorgs, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants