Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requested new locales #4949

Closed
3 of 6 tasks
marwahaha opened this issue Jan 17, 2019 · 5 comments
Closed
3 of 6 tasks

Requested new locales #4949

marwahaha opened this issue Jan 17, 2019 · 5 comments

Comments

@marwahaha
Copy link
Member

marwahaha commented Jan 17, 2019

These locales have been requested. Please add them if you can!

How to add a new locale:

  • Verify the ISO 639 code.
  • Copy the src/locale/en-gb.js file or similar into src/locale/<XX>.js and update for the new language.
  • Copy the src/test/locale/en-gb.js file or similar into src/test/locale/<XX>.js and update for the new locale.
  • Go to the command line, navigate to this project, and run grunt. All the tests should pass.
  • Make a pull request!

Requesting a new locale

comment on this issue, and i can add it to the main issue text.

@ABhakuni
Copy link

Is this resolved? If not, I would like to take it

@bukkysos
Copy link

Created a new locale (Igbo language, Nigeria). Test has been throwing error: "
**Actual value:
2 02 2nd
Expected value:
1 01 1st

Warning: 199 tests failed Use --force to continue.

Aborted due to warnings.**
"
Need help. Anyone, please??

@Krinkle
Copy link

Krinkle commented Aug 14, 2020

It might be better to invest in supporting CLDR and/or native Intl so that you get these, and a few hundred more languages, for free bascially.

Either by consuming CLDR upstream data directly, or through the cldr.js package that spun out of Globalize (ref #1241).

@maxammann
Copy link

Sounds like a good idea. CLDR also supports Tigrinia. To check for support download core.zip here: https://unicode.org/Public/cldr/37/

@marwahaha
Copy link
Member Author

See https://momentjs.com/docs/#/-project-status/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants