Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale for Tigrinya (ti) is not supported #5438

Closed
maxammann opened this issue Apr 7, 2020 · 10 comments
Closed

Locale for Tigrinya (ti) is not supported #5438

maxammann opened this issue Apr 7, 2020 · 10 comments

Comments

@maxammann
Copy link

Describe the bug
The locales for Tigrinya are missing.

To Reproduce
Steps to reproduce the behavior:

  1. Requesting the ti locale fails

Expected behavior
The ti locale should be supported.

Desktop (please complete the following information):

  • OS: any
  • Browser any
  • Version any

Smartphone (please complete the following information):

  • Device: any
  • OS: any
  • Browser any
  • Version: any

Moment-specific environment

  • The time zone setting of the machine the code is running on: Europe/Berlin
  • The time and date at which the code was run: 07. Aril 2020
  • Other libraries in use (TypeScript, Immutable.js, etc): none

require('moment').locale('ti') returns 'en'

Additional context
none

@maxammann maxammann changed the title Locales for Tigrinya (ti) are not supported Locale for Tigrinya (ti) is not supported Apr 7, 2020
@Alanscut
Copy link
Contributor

@maxammann you should create a locale setting with your customizations.this is a very cool feature provided by moment.
https://momentjs.com/docs/#/customization/

@maxammann
Copy link
Author

Problem is that I do not speak Tigrinya but our app should support it.

Maybe we can find somebody knowledgeable :)

@Alanscut
Copy link
Contributor

The authors and members of this library may be busy with other work. This is a very awkward situation. Maybe we can use a translator :).

@maxammann
Copy link
Author

I'll discuss this within our project. Maybe we can do something

@maxammann
Copy link
Author

I think we can make a proposal and let it check by a professional translator: https://lh.2xlibre.net/locale/ti_ER/

@maxammann
Copy link
Author

Is there a procedure from the moment.js for adding locales? My current Idea would be to create the locale and then generate sample sentences which can be checked by non-tech professional translators.

@Alanscut
Copy link
Contributor

Alanscut commented Apr 23, 2020

You can express your thoughts on gitter : (https://gitter.im/moment/moment)

@yosiasz
Copy link

yosiasz commented Apr 29, 2020

Amharic Tigrinya Speaker here. How can I help @maxammann

@Alanscut
Copy link
Contributor

Alanscut commented May 8, 2020

@yosiasz See https://github.com/moment/moment/blob/develop/src/locale/en-ie.js and https://momentjs.com/docs/#/i18n/ . Add Tigrinya internationalization support.

@marwahaha marwahaha mentioned this issue May 12, 2020
6 tasks
@marwahaha
Copy link
Member

Sure, we'd look at a PR for this.
I closed it in favor of #4949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants