Do not dynamically assign modProcessorResponse to modConnectorResponse #16563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result is used within a single method, so there is no need to assign the result from runProcessor to a property of modConnectorResponse dynamically, or to add a property to modConnectorResponse to hold the result.
opengeek
added
the
bug
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Assign the processor result to a local variable rather than dynamically creating a "response" property on the modConnectorResponse class.
Why is it needed?
In PHP 8.2, dynamically assigning a property to a class is deprecated. When calling runProcessor, the result is only used within the
outputContent()method, so there is no need to assign the result from runProcessor to a property of modConnectorResponse dynamically or add a property to modConnectorResponse to hold the result.How to test
Confirm no deprecated warnings are logged when running a processor in a connector.
Related issue(s)/PR(s)
Alternative solution to #16562