Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Dynamic property modConnectorResponse::$response PHP8 #16566

Closed
webinmd opened this issue Apr 28, 2024 · 1 comment
Closed

[2.x] Dynamic property modConnectorResponse::$response PHP8 #16566

webinmd opened this issue Apr 28, 2024 · 1 comment
Labels
bug The issue in the code or project, which should be addressed.

Comments

@webinmd
Copy link
Contributor

webinmd commented Apr 28, 2024

Bug report

Summary

Deprecated: Creation of dynamic property modConnectorResponse::$response is deprecated in /public_html/core/model/modx/modconnectorresponse.class.php on line 145

Step to reproduce

Any code in the component modalConsole

Can be fixed if declared $response in core/model/modx/modconnectorresponse.class.php

Environment

MODX 2.8.7, PHP 8.2
@webinmd webinmd added the bug The issue in the code or project, which should be addressed. label Apr 28, 2024
@webinmd webinmd changed the title Dynamic property modConnectorResponse::$response PHP8 Dynamic property modConnectorResponse::$response PHP8, MODX 2.8.7 Apr 28, 2024
@webinmd webinmd changed the title Dynamic property modConnectorResponse::$response PHP8, MODX 2.8.7 [2.x] Dynamic property modConnectorResponse::$response PHP8 Apr 28, 2024
@halftrainedharry
Copy link
Contributor

halftrainedharry commented Apr 28, 2024 •
edited

There already exists a pull request to fix this: #16563

@webinmd webinmd closed this as completed Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue in the code or project, which should be addressed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webinmd @halftrainedharry