Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs with extending the session handler class #15934

Closed
wants to merge 2 commits into from
Closed

Fix bugs with extending the session handler class #15934

wants to merge 2 commits into from

Conversation

sergant210
Copy link
Collaborator

What does it do?

  1. Fixes the bugs from issue Logout all users action doesn't work with custom session handlers #15928.
  2. Refactoring inititialization of the session handler.

How to test

See the issue.

Related issue(s)/PR(s)

#15928.

@Ibochkarev Ibochkarev added this to the v3.0.0-rc1 milestone Dec 7, 2021
@Ibochkarev Ibochkarev added the pr/review-needed Pull request requires review and testing. label Dec 7, 2021
opengeek
opengeek reviewed Dec 7, 2021
View reviewed changes
core/src/Revolution/modX.php Show resolved Hide resolved
core/src/Revolution/modX.php Show resolved Hide resolved
@opengeek opengeek removed this from the v3.0.0-rc1 milestone Dec 7, 2021
@sergant210 sergant210 changed the title Fixed bugs with extending of the session handler class Fix bugs with extending the session handler class Dec 8, 2021
@JoshuaLuckers

This comment has been minimized.

Sign in to view
@cla-bot

This comment has been minimized.

Sign in to view
@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Dec 17, 2021
@Mark-H Mark-H self-requested a review January 16, 2022 23:48
@Mark-H Mark-H added this to the v3.0.0-rc2 milestone Jan 19, 2022
@theboxer theboxer mentioned this pull request Feb 1, 2022
Closed
@opengeek opengeek modified the milestones: v3.0.0-rc2, v3.0.0-pl Feb 3, 2022
@opengeek opengeek modified the milestones: v3.0.0, v3.0.1 Mar 29, 2022
@opengeek opengeek modified the milestones: v3.0.1, v3.0.2 Apr 28, 2022
@opengeek opengeek modified the milestones: v3.0.2, v3.0.3 Nov 16, 2022
@opengeek opengeek modified the milestones: v3.0.3, v3.1.0 Jan 17, 2023
@rthrash
Copy link
Member

rthrash commented Feb 2, 2023

This pull request has been mentioned on MODX Community. There might be relevant details there:

https://community.modx.com/t/error-flush-sessions-not-supported-when-trying-to-logout-all-users-in-modx-3/6361/2

@rthrash
Copy link
Member

rthrash commented Feb 2, 2023

This pull request has been mentioned on MODX Community. There might be relevant details there:

https://community.modx.com/t/error-flush-sessions-not-supported-when-trying-to-logout-all-users-in-modx-3/6361/7

@Mark-H Mark-H mentioned this pull request Feb 10, 2024
Open
@Mark-H
Copy link
Collaborator

Mark-H commented Feb 10, 2024

Closing in favour of #16522 - please see my explanation there.

@Mark-H Mark-H closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opengeek opengeek opengeek left review comments

@Mark-H Mark-H Awaiting requested review from Mark-H Mark-H is a code owner

Assignees
No one assigned
Labels
cla-signed CLA confirmed for contributors to this PR. pr/review-needed Pull request requires review and testing.
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sergant210 @JoshuaLuckers @rthrash @Mark-H @opengeek @Ibochkarev