Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modSessionHandlerInterface #15957

Closed
wants to merge 3 commits into from
Closed

Conversation

theboxer
Copy link
Member

@theboxer theboxer commented Jan 6, 2022

What does it do?

  • Creates a modSessionHandlerInterface interface and uses it for modSessionHandler
  • Moves flushSessions method from Security\Flush processor to the interface & handler
  • In the Security\Flush processor - checks if flushSessions method exists in the handler class stored in session_handler_class system setting and executes it if so

Why is it needed?

Custom session handlers can't flush all sessions.

How to test

#15928

Related issue(s)/PR(s)

Resolves #15928

@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Jan 6, 2022
@theboxer theboxer added this to the v3.1.0 milestone Jan 6, 2022
@Ibochkarev Ibochkarev added the pr/review-needed Pull request requires review and testing. label Jan 8, 2022
@JoshuaLuckers
Copy link
Contributor

@sergant210 can you check if this PR solves your issue?

@theboxer
Copy link
Member Author

theboxer commented Feb 1, 2022

btw. this is kind of duplicate of #15934 I didn't notice that PR sooner

@sergant210
Copy link
Collaborator

sergant210 commented Feb 18, 2022

@JoshuaLuckers My PR solves my issue ;)

@opengeek
Copy link
Member

My PR is solves my issue ;)

This was not the question.

@JoshuaLuckers
Copy link
Contributor

@theboxer can you explain the main difference between this PR and #15934 ? I don't have enough time to look into the details to decide which one we should approve and merge.

@Ibochkarev
Copy link
Collaborator

Up

@rthrash
Copy link
Member

rthrash commented Feb 2, 2023

This pull request has been mentioned on MODX Community. There might be relevant details there:

https://community.modx.com/t/error-flush-sessions-not-supported-when-trying-to-logout-all-users-in-modx-3/6361/2

@Mark-H
Copy link
Collaborator

Mark-H commented Feb 10, 2024

Closing in favour of #16522 - please see my explanation there.

@Mark-H Mark-H closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for contributors to this PR. pr/review-needed Pull request requires review and testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logout all users action doesn't work with custom session handlers
7 participants