Updating MOAI Xcode sample project settings so they compile again #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et will compile again on macOS. Needed to raise the deployment target, remove references to `libcrypto.dylib` and `libssl.dylib`, set `LIBRARY_SEARCH_PATHS` to `$(SDKROOT)/usr/lib/system`, and set the `customWorkingDirectory` value in the `Run` scheme to a Lua sample from the `$PROJECT_DIR/../../samples/anim/anim-basic` directory. Phew!
…13.0`. Believe it or not, we are no longer using iOS `4.3`! I also set changed the architectures to `$(ARCHS_STANDARD)` since `$(ARCHS_STANDARD_32_BIT)` hasn't worked for years.
…ier to `com.elevate.moaisample` for now.
…urces" build phase.
…ker Flags" entry under the "Linking" section of the MoaiSample Build Settings tab.
… `Build Settings` group under `libmoai.xcodeproj`.
…the unique ID of each touch event, and that no longer compiles, use the last 32 bits of the 64-bit pointer, and pass that in.
…e preventing the app from compiling. We'll probably need to do something else to clean them up later.
…gets), and under the "Deployment (unnamed domain)" section, setting the `IPHONEOS_DEPLOYMENT_TARGET` to `13.0`.
aab29
requested review from
jerelevine,
jpoka,
andrewcousins7 and
AaronElevate
jpoka
reviewed
Jan 4, 2021
| @@ -505,33 +564,41 @@ | |||
| 1D6058940D05DD3E006BFB54 /* Debug */ = { | |||
| isa = XCBuildConfiguration; | |||
| buildSettings = { | |||
| ALWAYS_SEARCH_USER_PATHS = NO; | |||
| DEVELOPMENT_TEAM = JG69W4K637; | |||
There was a problem hiding this comment.
Is this development team id for a personal account? If so we might want to unset that.
jpoka
approved these changes
Jan 4, 2021
|
Wanted to check in on what the development plan is for this update project. Should we have a base feature branch that we should be merging these incremental updates into and keep it as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first step in getting MOAI to run with MetalANGLE on the
mindsnacks-devbranch is to get MOAI's sample Xcode projects (included in this repository) to compile again. They haven't been updated in years, and stopped working a long time ago. 🏛️ Many changes were made to themoai-devdevelop branch since we forked off from it. 🍴 I've been trying to figure out which changes to copy over from the Xcode projects on the main fork to make our Xcode projects compile again. ⬅️This PR is what I think is the minimum set of changes needed to get just the iOS Xcode project to run. 📱 The iOS project currently compiles and installs on my iPhone, but it won't open when I install from my work computer.⚠️ I'm sure this is happening because I don't have my provisioning profiles set up correctly, but it should work fine once we sort that out. 🔀
I haven't tried getting the "
osx" project to work yet, but I should be able to follow similar steps to get it working. 💻Note that in order to get the iOS sample project to run, you must copy the contents of a Lua example folder from the
samplesdirectory intoxcode/ios/lua. I think theanim-basicfolder is a good one to use because it doesn't try to do anything fancy. 🚫🧐Also note that this PR does not include any of the changes needed to get MetalANGLE running. 🙅 Those changes are on a separate branch on top of this PR that I'm still working on... but I'm optimistic that I can get something working soon. 🤞🤞
Also also note that we'll want to do some cleanup before we merge this PR. 🧹 I just wanted to get the changes out there for now. 👐