Skip to content

Prepend cmake to our diagnostics#4766

Merged
gcampbell-msft merged 9 commits intomainfrom
dev/gcampbell/PrependDiagnostics
Mar 2, 2026
Merged

Prepend cmake to our diagnostics#4766
gcampbell-msft merged 9 commits intomainfrom
dev/gcampbell/PrependDiagnostics

Conversation

@gcampbell-msft
Copy link
Copy Markdown
Collaborator

The vscode.Diagnostics object has a source field that predominantly has been used by extensions to indicate what extension the diagnostic is being contributed to the Problems pane by.

This PR appends cmake before other information so that it can be more obvious that the diagnostics are coming from our extension.

Before

image

After

image

hanniavalera
hanniavalera previously approved these changes Feb 26, 2026
@hanniavalera hanniavalera force-pushed the dev/gcampbell/PrependDiagnostics branch from e530bae to 74248fd Compare February 26, 2026 20:54
@gcampbell-msft
Copy link
Copy Markdown
Collaborator Author

@copilot The tests are failing, can you investigat

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 26, 2026

@gcampbell-msft I've opened a new pull request, #4767, to work on those changes. Once the pull request is ready, I'll request review from you.

@gcampbell-msft
Copy link
Copy Markdown
Collaborator Author

@copilot code review[agent] fix the test issues

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 26, 2026

@gcampbell-msft I've opened a new pull request, #4768, to work on those changes. Once the pull request is ready, I'll request review from you.

snehara99
snehara99 previously approved these changes Feb 27, 2026
@gcampbell-msft gcampbell-msft dismissed stale reviews from snehara99 and hanniavalera via 727c755 March 2, 2026 15:05
@gcampbell-msft gcampbell-msft merged commit b69f08d into main Mar 2, 2026
4 checks passed
@gcampbell-msft gcampbell-msft deleted the dev/gcampbell/PrependDiagnostics branch March 2, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants