Add visualStudioArguments for MSVC kit and handle it properly#4619
Add visualStudioArguments for MSVC kit and handle it properly#4619mcodilla merged 3 commits intomicrosoft:mainfrom
Conversation
|
cc @gcampbell-msft ping for take a look |
6def04e to
91a7a1d
Compare
45df361 to
7e04d7f
Compare
7a930ae to
9e7029c
Compare
|
Hey @lygstate, thanks for the contribution! the change generally looks reasonable, there are just a couple of things we’d like to address before merging The current structure looks like a string array where meaning is implied by order. That makes it a bit hard to reason about. Would you be willing to revise this to a more self-describing structure (for example, a JSON object so each value's purpose is explicit)? If you’re up for making those adjustments, I think we’d be in a good place to proceed |
I would keep this, if MSVC have more arguments in future, then we have no need update the code. |
|
That makes sense. Let's proceed with this as is. All that is needed at this point is a changelog update. Would you be willing to add that in? |
9e7029c to
1e241bf
Compare
1e241bf to
353a182
Compare
… 2015 directly Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
This is support for specify custom Windows SDK Kit. Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
353a182 to
45888eb
Compare
This changes Select SDK under Windows
This is partially for #125
And this is also can be used to implement
Closes: #1905
Closes: #1379
The following changes are proposed:
A new visualStudioArguments is provided.
The purpose of this change
As the newest windows sdk is not compatible with MSVC 2015, so we need stick to specific version of windows sdk
by using
visualStudioArguments