Skip to content

Add visualStudioArguments for MSVC kit and handle it properly#4619

Merged
mcodilla merged 3 commits intomicrosoft:mainfrom
lygstate:add-visualStudioArguments-v1.20
Apr 8, 2026
Merged

Add visualStudioArguments for MSVC kit and handle it properly#4619
mcodilla merged 3 commits intomicrosoft:mainfrom
lygstate:add-visualStudioArguments-v1.20

Conversation

@lygstate
Copy link
Copy Markdown
Contributor

@lygstate lygstate commented Nov 24, 2025

This changes Select SDK under Windows

This is partially for #125
And this is also can be used to implement

Closes: #1905
Closes: #1379

The following changes are proposed:
A new visualStudioArguments is provided.

The purpose of this change

As the newest windows sdk is not compatible with MSVC 2015, so we need stick to specific version of windows sdk
by using visualStudioArguments

@lygstate lygstate changed the title Add visual studio arguments v1.20 Add visualStudioArguments for MSVC kit and handle it properly Nov 26, 2025
@lygstate
Copy link
Copy Markdown
Contributor Author

cc @gcampbell-msft ping for take a look

@lygstate lygstate force-pushed the add-visualStudioArguments-v1.20 branch from 6def04e to 91a7a1d Compare December 28, 2025 09:08
@lygstate lygstate force-pushed the add-visualStudioArguments-v1.20 branch 2 times, most recently from 45df361 to 7e04d7f Compare January 29, 2026 21:45
@hanniavalera hanniavalera force-pushed the add-visualStudioArguments-v1.20 branch from 7a930ae to 9e7029c Compare April 6, 2026 17:01
@mcodilla
Copy link
Copy Markdown
Contributor

mcodilla commented Apr 6, 2026

Hey @lygstate, thanks for the contribution! the change generally looks reasonable, there are just a couple of things we’d like to address before merging

The current structure looks like a string array where meaning is implied by order. That makes it a bit hard to reason about. Would you be willing to revise this to a more self-describing structure (for example, a JSON object so each value's purpose is explicit)?

If you’re up for making those adjustments, I think we’d be in a good place to proceed

@lygstate
Copy link
Copy Markdown
Contributor Author

lygstate commented Apr 6, 2026

Hey @lygstate, thanks for the contribution! the change generally looks reasonable, there are just a couple of things we’d like to address before merging

The current structure looks like a string array where meaning is implied by order. That makes it a bit hard to reason about. Would you be willing to revise this to a more self-describing structure (for example, a JSON object so each value's purpose is explicit)?

If you’re up for making those adjustments, I think we’d be in a good place to proceed

I would keep this, if MSVC have more arguments in future, then we have no need update the code.

@mcodilla
Copy link
Copy Markdown
Contributor

mcodilla commented Apr 6, 2026

That makes sense. Let's proceed with this as is. All that is needed at this point is a changelog update. Would you be willing to add that in?

@hanniavalera hanniavalera force-pushed the add-visualStudioArguments-v1.20 branch from 9e7029c to 1e241bf Compare April 7, 2026 17:28
@lygstate lygstate force-pushed the add-visualStudioArguments-v1.20 branch from 1e241bf to 353a182 Compare April 8, 2026 08:52
@mcodilla mcodilla enabled auto-merge (squash) April 8, 2026 17:41
lygstate added 3 commits April 8, 2026 14:18
… 2015 directly

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
This is support for specify custom Windows SDK Kit.

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
@mcodilla mcodilla force-pushed the add-visualStudioArguments-v1.20 branch from 353a182 to 45888eb Compare April 8, 2026 21:19
@mcodilla mcodilla merged commit a9f2c7f into microsoft:main Apr 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

detecting vs2015 comes with vs2019 properly Cmake-tools does not send Windows SDK version to cpptools

2 participants