This repository has been archived by the owner on Jun 30, 2022. It is now read-only.
[TypeScript][Virtual Assistant & Skill] Implement Dependency Injection #3559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
darrenj,
lauren-mills,
lzc850612,
pavolum,
peterinnesmsft,
ryanisgrig,
sidmore and
taicchoumsft
lzc850612
approved these changes
Aug 13, 2020
peterinnesmsft
added
the
Language: Typescript
...ot-virtualassistant/generators/app/templates/sample-assistant/src/adapters/defaultAdapter.ts
Outdated
Show resolved
Hide resolved
...rator-bot-virtualassistant/generators/app/templates/sample-assistant/src/inversify.config.ts
Outdated
Show resolved
Hide resolved
...-bot-virtualassistant/generators/skill/templates/sample-skill/src/dialogs/skillDialogBase.ts
Outdated
Show resolved
Hide resolved
templates/typescript/samples/sample-skill/src/bots/defaultActivityHandler.ts
Show resolved
Hide resolved
templates/typescript/samples/sample-skill/src/dialogs/skillDialogBase.ts
Outdated
Show resolved
Hide resolved
...rator-bot-virtualassistant/generators/app/templates/sample-assistant/src/inversify.config.ts
Show resolved
Hide resolved
...rator-bot-virtualassistant/generators/app/templates/sample-assistant/src/inversify.config.ts
Show resolved
Hide resolved
...rator-bot-virtualassistant/generators/app/templates/sample-assistant/src/inversify.config.ts
Show resolved
Hide resolved
...rator-bot-virtualassistant/generators/app/templates/sample-assistant/src/inversify.config.ts
Outdated
Show resolved
Hide resolved
...rator-bot-virtualassistant/generators/app/templates/sample-assistant/src/inversify.config.ts
Outdated
Show resolved
Hide resolved
...rator-bot-virtualassistant/generators/app/templates/sample-assistant/src/inversify.config.ts
Outdated
Show resolved
Hide resolved
peterinnesmsft
suggested changes
Sep 2, 2020
|
Thanks @peterinnesmsft for the feedback! We will be reviewing this as soon as possible. |
|
@peterinnesmsft - we already applied the requested changes mentioned above! |
...-virtualassistant/generators/skill/templates/sample-skill/src/bots/defaultActivityHandler.ts
Outdated
Show resolved
Hide resolved
Batta32
deleted the
feature/southworks/dependency-injection-implementation
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3496
Purpose
What is the context of this pull request? Why is it being done?
We introduced
inversifyjslibrary in order to add Dependency Injection functionality following parity with C#.Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
The following changes were replicated in Virtual Assistant and Skill:
tsconfig.jsonto be able to use Dependency Injectionconstantandinversify.config.tsfiles to configure Dependency Injection functionalitypackage.jsonaddinginversifyjsandreflect-metadatalibrariesTests
Is this covered by existing tests or new ones? If no, why not?
-
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-
Checklist
General