QnAMakerDialog is not created for different languages #3496
Comments
Thanks @tommyJimmy87. As soon as we have any update related to the Dependency Injection's implementation, we will back to you! |
Hi @tommyJimmy87, we created the PR #3559 which solves this problem incorporating Dependency Injection in the bots. If you are so kind, can you validate the changes following these repro steps and using this branch:
Last but not least, as it was mentioned, the PR contains the following changes:
We will be attentive to your answer 😊. |
Hi @Batta32, thanks for your support, looks like the issue has been solved with the new bot-solutions library that I integrated from your branch :) Do you have a rough estimation to when you're going to release it? |
HI @Batta32, I was noticing that when I try to run the unit tests I get an error : |
Thanks @tommyJimmy87! We will be reviewing this and we will back to you as soon as we have any update of this 😊. |
Hi @Batta32, we solved this problem adding this import to the test base js file : |
Hi @tommyJimmy87 - we couldn't reproduce the issue that you mentioned related to the unit tests. We came up with questions:
This is our environment:
We took the following steps to reproduce the issue for the Virtual Assistant and the Skill:
|
Hi @tommyJimmy87 - we added the suggested changes in the PR #3559. We updated the Virtual Assistant & Skill bots adding the following import tests files: You can follow up these steps to test the changes in the Virtual Assistant and Skill. Thanks, |
Hi @Batta32 and @DiegoCardozo94, I have one a generic question but since I'm using this Branch in our project already even though has not been released I would ask it here. In our scenario, we have MS Teams as the only channel, I see that the TeamsActivityHandler is used only in the VA and not in the skill's sample, is that right? Because maybe wrongly I was extending also in the skill the TeamsActivityHandler and that drove me to one issue specifically: basically the Thanks |
Hi @tommyJimmy87, the The Virtual Assistant is the one which interacts to the Microsoft Teams Channel in the schema of Virtual Assistant connected to Skills, so the The We researched the following documentation that you can also review:
Let us know if this helps to you 😊. |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
@Batta32 this is not yet released right? |
Hi @tommyJimmy87 - we are finalizing a plan to release new packages. As soon as we have any update we will back to you here 😊. |
@Batta32 any updates? |
Hi @cwhitten, this issue is already fixed with the PR #3559 which is updated with the requested changes of @peterinnesmsft . As soon as the PR is merged, the changes will be present in the |
Hi @tonyanziano, the PR #3559 is ready to be reviewed and merged containing the requested changes of @peterinnesmsft. As soon as the PR is merged, the changes will be present in the |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
@joshgummersall what is the status of #3752? When do you expect to merge that in? |
Just as soon as someone else can review it and approve! |
Can you work to get the PR merged so this ticket can be closed? |
@Virtual-Josh, it's just waiting on one more PR review; it's been approved by one reviewer already. Not sure who to ping for a second review. |
What project is affected?
Virtual Assistant and Skills
What language is this in?
Typescript
What happens?
When a QnAMakerDialog is created with a specific language (ex. DE) will be resolving always that language even though you change the language or another user uses a different language (ex EN).
What are the steps to reproduce this issue?
User 1: Sends utterance to the bot ( DE );
Bot: The Bot resolves the utterance as QnA intent, and create the new QnADialog, with the knowledgebaseId as Id of the Dialog:
Bot: Sends QnA Answer to User 1 in User 1's locale ( DE )
User 2: Sends utterance to bot ( EN );
Bot: The Bot resolves the utterance as QnA intent ( same the user 1 sent ), no new QnaMakerDialog is created because one Dialog with the same knowledgebaseId already exists.
Bot: The Bot start again the QnA Dialog (added from user 1 iteration) and get the answer from the Knowledge Base (DE) of the first user;
Bot: Sends Message to User 2 in User 1's locale.
What were you expecting to happen?
Another QnAMakerDialog will be created with the right language and right knowledge base ID.
The text was updated successfully, but these errors were encountered: