New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Drop python 39 #5620
Open
jenshnielsen
wants to merge
6
commits into
main
Choose a base branch
from
drop_python_39
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
RFC: Drop python 39 #5620
+1,733
−1,775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5620 +/- ##
==========================================
- Coverage 66.39% 66.36% -0.04%
==========================================
Files 354 354
Lines 30965 30964 -1
==========================================
- Hits 20560 20549 -11
- Misses 10405 10415 +10 |
jenshnielsen
force-pushed
the
drop_python_39
branch
from
April 30, 2024 12:06
92df777
to
178a442
Compare
astafan8
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exciting :) and removing 3.9 ci and updating readme is still todo
jenshnielsen
force-pushed
the
drop_python_39
branch
from
May 8, 2024 18:56
178a442
to
c9e9fa5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the scientific python stack has adopted SPEC 0 which means that python 3.9 support should be dropped from late 2023. As an example we can see in #5602 that Ipython has dropped support for 3.9.
This is to propose that QCoDeS also drops support for 3.9