OV-Chipkaart: Create fake tagOn for busses that replace them #851
+43
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, several of my bus transactions are missing tagOn events entirely, with a clear gap in the transaction IDs, and instead they left a tagOff event with a Trip Duration field. While it's very nice of them to help use the 28 transactions sparingly, the TripTransaction correlation would appreciate having a tagOn event to show the trip length in the trip log.
So, this change inserts fake tagOn events starting at the right time before the tagOff event.
This will conflict with my other PRs, I'm prepared to update things as changes are requested and things are merged! <3