orca: Handle hand-held readers better (fixes #681) #811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both Seattle Monorail and Water Taxis use KCM's agency ID and hand-held readers, and vehicle number 3. We previously marked these as Monorail, but the Water Taxi also uses vehicle Number 3. We don't have enough info to be able to tell these apart, so for now, just mark these all as "point of sale". While here, also show the `file` and `rec` IDs in the "raw data" fields. This makes debugging much easier.
|
I like this solution! |
|
See also #757 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both Seattle Monorail and King County Water Taxis use KCM's agency ID and hand-held readers, and vehicle number 3. We previously marked these as Monorail, but the Water Taxi also uses vehicle Number 3. 馃槥
We don't have enough info to be able to tell these apart, so for now we'll mark these all as "point of sale", and show the
mCoachNumas the "Machine ID" (though this will probably always be 3).While here, I added the
fileandrecIDs to the "raw data" fields. This makes debugging much easier.Tested this with a dump provided by @phcoder with a Water Taxi trip, shown below (with raw mode on):
This should let us close #681.
cc: @cookieguru, @frozenpandaman