Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for several guesses at user region #781

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phcoder
Copy link
Collaborator

@phcoder phcoder commented Oct 30, 2021

This is meant for discussion, not necessarily for merge

@micolous
Copy link
Collaborator

micolous commented Jun 3, 2022

It sounds like the proposal is:

  • Metrodroid would provide a list of regions, rather than a single region. All cards matching one of those regions would be considered "nearby".
  • Metrodroid would consider all active SIMs as sources of data in the device, not just the primary SIM.
  • Metrodroid would always consider the locale setting as a source of data, not just when a device doesn't have a cellular network connection.

I originally avoided using the device locale because many devices were set to en-gb or en-us, even when they're not ever used in those countries, and it could be perceived as some sort of bias on the developers' part (when in fact, we're using device preferences). The same may be true for other languages which are spoken in multiple countries/regions.

Evaluating that again now for the current versions of Android and iOS:

  • Current versions of Android and iOS provide much more fine-grained locale settings, in part because many carriers require devices have an option for their local dialect. As a result, it's more likely to match user intent – a user in Australia is more likely to use en-au than en-gb.

  • For those travelling internationally, a user having their home country still show up is not unexpected (and it would probably show up anyway if using international roaming).

  • For those who intentionally set their device language to a dialect other than the one spoken locally (eg: using en-us in UK), that's too hard to fix. 😅

  • For those who set their device language to a language other than an official language in the country they reside, this change could still muddy the "nearby" property (eg: an English speaker in Switzerland may see UK or US as "nearby" options, if they did not pick "English (Switzerland)" – and it may not even be available), but it is not entirely unexpected.

Overall though, I think this change is a net positive. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants