WIP: start implementing Ravkav GTFS support #772
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phcoder
reviewed
Nov 1, 2021
| /* A map of language codes (two-letter ISO code) to language ID, local to | ||
| * this file, used for `Names.other` and `Names.other_short`. | ||
| */ | ||
| map<string, uint32> languages = 7; |
There was a problem hiding this comment.
I think we need more than just id. I think it needs to map to a message containing ID but also e.g. which is primary local language. E.g. on English system if the checkbox "show local language" is on and we scan Rav-Kav then Hebrew will be the language to show. Other attributes might include tts hints. Hebrew omits vowels and I can imagine having 2 IDs for Hebrew: first one is used for display purposes (E.g for Haifa: חיפה) and second one with vowels (חֵיפָה) is retrieved but not shown and instead is stuffed into tts hints. For this we need a second field in language message which species the key for tts hints. Obviously tts hints is for the future but let's the design be expandable for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative for #751