Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make changes required for submission to App Store #731

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

robbiet480
Copy link
Contributor

@robbiet480 robbiet480 commented Feb 20, 2020

  • Set target version and SDK to 13.0
  • Disable iPad support as it doesn't have NFC hardware
  • Set version to 3.0.0 (1)
  • Update ZIPFoundation
  • Fix NFC entitlement as per this SO answer (fixes ERROR ITMS-90778: "Invalid entitlement for core nfc framework. The sdk version '13.2' and min OS version '13.0' are not compatible for the entitlement 'com.apple.developer.nfc.readersession.formats' because 'NDEF is disallowed'.")
  • Remove alpha channel from 1024px App Store icon (fixes ERROR ITMS-90717: "Invalid App Store Icon. The App Store Icon in the asset catalog in 'metrodroid.app' can't be transparent nor contain an alpha channel.")
  • Set default team at the project instead of target level
  • Replace IOS in the README supported cards list with 馃崕

@robbiet480
Copy link
Contributor Author

I suggest we get the work done to fix the icon issues mentioned in #730 in this PR.

Copy link
Collaborator

@micolous micolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets work out the logo policy issues fully in another PR.

It looks like Xcode has got some problems with generating JSON files hermetically, which has added some noise (ergh). I'll need to get my toolchain up to date before I can review this fully.

Using a `git@github.com` requires a GitHub account, and that it is configured in Xcode.

Xcode/swiftpm will roll back changes to `Package.resolved` unless
`project.pbxproj` is updated.  It will also delete `Package.resolved` if it
can't successfully check it.

More detail on Swift Forums:
https://forums.swift.org/t/package-resolved-should-go-in-the-gitignore/14699/6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants