Skip to content
This repository has been archived by the owner on May 13, 2021. It is now read-only.

added facetAttributes in Model #109

Closed
wants to merge 4 commits into from
Closed

Conversation

bsormagec
Copy link

I try to add quickly facetAttributes option to models to use it for filtering on product or something searching.

@curquiza curquiza mentioned this pull request Mar 10, 2021
@curquiza
Copy link
Member

curquiza commented Mar 10, 2021

Hello @bsormagec,

Thanks a lot for your PR and your involvement! :)
However, this PR includes a behavior we don't want to handle for the moment.
Indeed, as described in this issue I've just created (you're not the first one who are not aware of this) I explain we want to stay completely compliant with the original laravel/scout usage for the moment.
The way to update settings is described in our wiki here
I'm closing this PR but thank you anyway! It made me create the issue I linked 😊

@curquiza curquiza closed this Mar 10, 2021
@bsormagec
Copy link
Author

thank you @curquiza i just didn't know another way to do it, that's my fault. Now I see a way to do it another way :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants