Skip to content
This repository has been archived by the owner on May 13, 2021. It is now read-only.

The future of this repo #111

Closed
curquiza opened this issue Mar 10, 2021 · 17 comments
Closed

The future of this repo #111

curquiza opened this issue Mar 10, 2021 · 17 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@curquiza
Copy link
Member

curquiza commented Mar 10, 2021

Hello everyone,

With @shokme (the main author of this package) we decided for the plan of this repository to build an integration for Laravel Scout by staying completely compliant/conformed with the original laravel/scout package.

The goal? To integrate this repository into the official laravel/scout package (as Algolia already is) by showing that people use it. We are working on this. We’ll keep you informed.

What does it mean? We did not integrate any contributions that would make the usage differ from the scout usage. Like this PR. The settings have to be handled in your models like we described in our wiki.

However, we would understand some of you would like a laravel-scout-extended integration, I mean with more friendly methods to handle settings in this repository, as this PR suggests.

The question: what do you think about making this repo an extended package and not only a strict integration with laravel-scout as we have right now?
For example, Algolia also did it with their scout-extended package.

I’m not saying it would be a priority task or an immediate and drastic change, we are not even sure this is the right choice to do, but we deeply believe it’s a good thing to have the community's opinion in mind when making decisions for the future of our repositories.
The PHP community is one of our most involved communities around MeiliSearch and all the Meili team would like to thank you for this! ❤️ Hope we will have your opinion here!

@curquiza curquiza added help wanted Extra attention is needed question Further information is requested labels Mar 10, 2021
@curquiza curquiza pinned this issue Mar 10, 2021
@mmachatschek
Copy link
Collaborator

@curquiza
I'm also a fan of this idea. There were already some PRs and issues related to extending this package. Providing a similar package as scout-extended for algolia would make the DX of MeiliSearch much better

@curquiza
Copy link
Member Author

Got it! The first step for me will be to create an issue in the laravel/scout repo to check if the maintainers are ok to integrate us.
Once they are ok, we have to do a PR on the laravel/scout repo, and I'm not sure the integration team will have time to do it soon...
And finally, once we have been integrated into laravel/scout (🤞) we should start thinking (and implementing) about how to improve this package. I think checking what Algolia did in scout-extended is a good start 😄

@curquiza
Copy link
Member Author

And thanks @mmachatschek for your return!! 😄

@mmachatschek
Copy link
Collaborator

mmachatschek commented Mar 19, 2021

@curquiza I already created a branch to add support for meilisearch here https://github.com/mmachatschek/scout/tree/add_meilisearch_support

As soon as you created the issue on the repo in the name of MeiliSearch I'll send in the PR

@mmachatschek
Copy link
Collaborator

@curquiza also I think that if the current state of this repo will be merged into laravel/scout this should be deprecated and a new repo should be created.
This package is not tagged as > 1.x and breaking changes can be introduced. But the main purpose of this package (creating a MeiliSearch client for laravel/scout) is not met anymore.

@curquiza
Copy link
Member Author

Thank you so much for your involvement @mmachatschek!! ❤️

I will discuss with the Meili team what to do with this repo next. I'm sad about giving up the most stared repository in the MeiliSearch integrations, even if 400 ⭐️ is not that much 😂 but you're right, it does not fit the first need.

I'll keep you informed.

@shokme
Copy link
Collaborator

shokme commented Mar 19, 2021

@mmachatschek you rock 😄

@curquiza
Copy link
Member Author

I've just asked laravel/scout-> laravel/scout#454
🤞

@driesvints
Copy link

We've just released Scout v9.0 with Meilisearch support.

@curquiza
Copy link
Member Author

curquiza commented Apr 28, 2021

Thank you so much @driesvints! 😁 All the Meili team is really excited by this news!

@driesvints
Copy link

@mmachatschek did the bulk of the work 🙂

@shokme
Copy link
Collaborator

shokme commented Apr 28, 2021

@curquiza So, what's the next step ?
how will we "deprecate" this package ?

@curquiza
Copy link
Member Author

@shokme, before doing anything I would like to have your opinion on this: do you think this is better to deprecate this repo and create a new one instead of "transforming" it?

I already have your opinion on this question @mmachatschek 😉 #111 (comment)

If anyone has any opinion to share, don't hesitate 🙂

@curquiza curquiza changed the title Make this repo an extended package for laravel-scout? The future of this repo Apr 29, 2021
@shokme
Copy link
Collaborator

shokme commented Apr 30, 2021

Indeed, I think this is better to deprecate this repo and create a new one.

@curquiza
Copy link
Member Author

curquiza commented May 3, 2021

I will discuss with the Meili team how to do this, and I will come back asap.
FYI, we don't currently have the human resources (at Meili) to create an extended integration for laraval scout (like this one), but the integration in the official laravel/scout should be enough for the moment 🙂

@shokme
Copy link
Collaborator

shokme commented May 3, 2021

@curquiza I understand. I'm still available to contribute if needed while keeping an eye open on the laravel/scout issues.

@curquiza
Copy link
Member Author

We have officially decided to deprecate this repo. I'm closing this issue and I open this one! I'm going to archive this repo 🙂
Thank you everyone for your help, we are lucky to have a community as involved as you are ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants