imgtool: initial sanity test (for CI build) #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 26, 2023
mingulov
force-pushed
the
fix/unittests
branch
from
9aa872d
to
02a80cc
Compare
mingulov
changed the title
davidvincze
reviewed
Nov 20, 2023
davidvincze
reviewed
Nov 21, 2023
davidvincze
reviewed
Nov 21, 2023
mingulov
force-pushed
the
fix/unittests
branch
2 times, most recently
from
e4c5ffd
to
8c7ed92
Compare
Add imgtool test call to workflows, use pytest and
publish artifacts with test results.
Also enable test run on 'pull_request', but limit
the previous default imgtool_run.sh run ('environment' job)
to run on 'push' event only (the same behaviour as before).
Signed-off-by: Denis Mingulov <denis@mingulov.com>
keys.KeyClass._emit is able to use 'file' parameter not as a file but some object (not only sys.stdout but io.StringIO, like by tests). Fixed all explicit checks for sys.stdio usage in favor of io.TextIOBase, also improve a single unit test to cover also all the changed methods. Signed-off-by: Denis Mingulov <denis@mingulov.com>
imgtool's dumpinfo depends to pyyaml package, so add it to requirements. Signed-off-by: Denis Mingulov <denis@mingulov.com>
An initial sanity test for imgtool is added, checks different commands for key operations (keygen, getpriv, getpub and getpubhash). Also very basic test for sign / verify is added. Some tests are disabled (marked as 'xfail') due to the missing implementation. Signed-off-by: Denis Mingulov <denis@mingulov.com>
mingulov
force-pushed
the
fix/unittests
branch
from
8c7ed92
to
be8acf9
Compare
mingulov
commented
Dec 15, 2023
davidvincze
approved these changes
Apr 2, 2024
Any updates on this? I'd like to merge this. |
|
I've tested the patch by manually triggering a CI build after rebase: https://github.com/davidvincze/mcuboot/actions/runs/9207789552 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imgtool tests are not used by CI (workflows), so even existing tests might be broken (or some other functionality, as described in #1769).
Modified workflows to use existing imgtool unittests also trigger it on 'pull_request'.
An initial sanity test for imgtool commands is added.
As some already existing unittests are broken, fix them to be able to start to use this change.
Added missing dependencies to setup.py / requirements.txt (it also prevented sanity test execution).
An example for CI build can be found here.