Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement imgtool sanity test in CI #1769

Open
davidvincze opened this issue Aug 4, 2023 · 4 comments
Open

Implement imgtool sanity test in CI #1769

davidvincze opened this issue Aug 4, 2023 · 4 comments

Comments

@davidvincze
Copy link
Collaborator

davidvincze commented Aug 4, 2023

It has happened before that basic functionalities, commands of imgtool have been broken (e.g. #1746) and it went unnoticed for a while. This issue wants to focus on and track the effort to get a new test implemented as part of the existing imgtool GitHub workflow.

This new sanity test can even be implemented as a Python unit test using one of the existing unit test frameworks or a simple basic bash script that invokes all the available commands of imgtool with different parameters and then compare the output with a known data set (e.g. signed template image, public key... ) to detect regression.

@mingulov
Copy link
Contributor

It would be nice.
After a brief check - it is even worse now, as #1752 has broken some existing imgtool unittests - so even existing tests are already partially broken as they are not executed by CI.
I have created that #1819 as a 1st step to have better imgtool test.

@davidvincze
Copy link
Collaborator Author

It would be nice. After a brief check - it is even worse now, as #1752 has broken some existing imgtool unittests - so even existing tests are already partially broken as they are not executed by CI. I have created that #1819 as a 1st step to have better imgtool test.

We've someone working on further additions to #1819 (in progress)

Copy link

This issue has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this issue will automatically be closed in 14 days. Note, that you can always re-open a closed issue at any time.

@github-actions github-actions bot added the stale label May 21, 2024
@davidvincze
Copy link
Collaborator Author

#1819 is in good state, should be merged soon.

@davidvincze davidvincze removed the stale label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants