-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for cke5 to allow link attributes #13725
Fix for cke5 to allow link attributes #13725
Conversation
234fe12
to
b4f9c5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no issues in the code. It fits the PR description, updates a lot of JS dependencies that all seem to be related to CK editor 👍
… Mautic 4 too, but less granular)
…it for adding custom highlights in placeholder text, or overriding link colors
8e1612d
to
58963d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.x #13725 +/- ##
============================================
- Coverage 61.51% 61.51% -0.01%
Complexity 34068 34068
============================================
Files 2241 2241
Lines 101852 101852
============================================
- Hits 62651 62650 -1
- Misses 39201 39202 +1 |
Tested locally, I can confirm it resolved the issue mentioned here: #13724. |
Description:
This partly reenables a feature that was present in Mautic 4: allowing for more html and html properties (attributes) to be printed inside CKE.
This change is limited to:
span
tags, with attributes (used by some email template makers for special highlights in placeholder text or even to override link colors)I also had to upgrade CKE (went from v38 to 41 ), because there was a bug that gave duplicate module errors when trying to import and add certain plugins.
When editing the contact block in the Brienz theme (and similar issues will arise in people's custom themes), the CKEditor gave a blank textarea, instead of letting you edit the existing text.
This was caused by some html attributes being in the prefilled Text Block. Instead of just the attributes being filtered out, the entire content disappeared.
Read the full bug report here
Steps to test this PR: