Skip to content

Commit

Permalink
Fix for cke5 to allow link attributes (#13725)
Browse files Browse the repository at this point in the history
* upgrade cke node modules to latest versions

* migrate some imports (names changed between v39 and 41)

* allow empty links (was a default setting in prev version)

* allow links to have various attributes in CKE (used to be the case in Mautic 4 too, but less granular)

* allow for spans to be used in cke html, since some custom themes use it for adding custom highlights in placeholder text, or overriding link colors

* uninstall html embed module (was accidentally added during cke modules update)

* remove code-block plugin for cke (also added prev by accident)

* changes from package json should be in scaffold version as well
  • Loading branch information
LordRembo committed May 10, 2024
1 parent a98a30f commit 3095439
Show file tree
Hide file tree
Showing 6 changed files with 1,288 additions and 1,527 deletions.
6 changes: 4 additions & 2 deletions app/assets/libraries/ckeditor/src/ckeditor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// The editor creator to use.
import { ClassicEditor as ClassicEditorBase } from '@ckeditor/ckeditor5-editor-classic';
import { Essentials } from '@ckeditor/ckeditor5-essentials';
import { UploadAdapter } from '@ckeditor/ckeditor5-adapter-ckfinder';
import { CKFinderUploadAdapter } from '@ckeditor/ckeditor5-adapter-ckfinder';
import { Autoformat } from '@ckeditor/ckeditor5-autoformat';
import { Bold, Italic, Underline, Code, Strikethrough, Subscript, Superscript } from '@ckeditor/ckeditor5-basic-styles';
import { BlockQuote } from '@ckeditor/ckeditor5-block-quote';
Expand All @@ -29,6 +29,7 @@ import { CloudServices } from '@ckeditor/ckeditor5-cloud-services';
import { Alignment } from "@ckeditor/ckeditor5-alignment";
import { RemoveFormat } from "@ckeditor/ckeditor5-remove-format";
import { SourceEditing } from "@ckeditor/ckeditor5-source-editing";
import { GeneralHtmlSupport } from "@ckeditor/ckeditor5-html-support";
import { Mention } from "@ckeditor/ckeditor5-mention";
import TokenPlugin from './TokenPlugin';

Expand All @@ -54,13 +55,14 @@ export default class ClassicEditor extends ClassicEditorBase {
FontBackgroundColor,
RemoveFormat,
SourceEditing,
GeneralHtmlSupport,
TokenPlugin,
FontColor,
FontFamily,
FontSize,
Essentials,
Underline,
UploadAdapter,
CKFinderUploadAdapter,
Autoformat,
Bold,
Italic,
Expand Down

0 comments on commit 3095439

Please sign in to comment.