Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Change stop engaging after a closing the focus to remove the negative wording when creating focus item #13616

Draft
wants to merge 1 commit into
base: 5.x
Choose a base branch
from

Conversation

andersonjeccel
Copy link
Contributor

@andersonjeccel andersonjeccel commented Apr 9, 2024

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

When creating a focus item, you have this option to decide whether the item should try again with the same user, at another time, if it was closed the first time.
This PR makes the question positive.

Before: Stop engaging after a closing the focus?
After: Engage again if dismissed?

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open Channels > Focus items > New > Builder
  3. Select the type "Display a notice" and see the new label

image

@andersonjeccel andersonjeccel marked this pull request as draft April 9, 2024 12:46
@andersonjeccel
Copy link
Contributor Author

@mallezie @LordRembo
I think this PR needs logic modification


I had this label:
Stop engaging after a closing the focus?

For this feature:

 $builder->add(
            'stop_after_close',
            YesNoButtonGroupType::class,
            [
                'label' => 'mautic.focus.form.stop_after_close',
                'data'  => (isset($options['data']['stop_after_close'])) ? $options['data']['stop_after_close'] : false,
                'attr'  => [
                    'tooltip' => 'mautic.focus.form.stop_after_close.tooltip',
                ],
            ]
        );

Changed to:
Engage again if dismissed?

How can I change the logic accordingly?

@andersonjeccel andersonjeccel added user-experience Anything related to related to workflows, feedback, and navigation WIP PR's that are not ready for review and are currently in progress enhancement Any improvement to an existing feature or functionality focus-items Anything related to focus items T1 Low difficulty to fix (issue) or test (PR) labels Apr 9, 2024
@LordRembo
Copy link
Contributor

@andersonjeccel a correction to my last comment:
If you want the logic to be inverted, I think you need to change the data line as it manages the No/Yes toggle state:
'data' => (isset($options['data']['stop_after_close'])) ? false : true,.

See if that produces the desired result (1. if it inverts the selected state and 2. see if the functionality behaves as expected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any improvement to an existing feature or functionality focus-items Anything related to focus items T1 Low difficulty to fix (issue) or test (PR) user-experience Anything related to related to workflows, feedback, and navigation WIP PR's that are not ready for review and are currently in progress
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants