Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Change "Stop engaging after a conversion?" to a positive statement #13617

Draft
wants to merge 1 commit into
base: 5.x
Choose a base branch
from

Conversation

andersonjeccel
Copy link
Contributor

Q A
Bug fix? (use the a.b branch) [ ]
New feature/enhancement? (use the a.x branch) [ ]
Deprecations? [ ]
BC breaks? (use the c.x branch) [ ]
Automated tests included? [ ]
Related user documentation PR URL mautic/mautic-documentation#...
Related developer documentation PR URL mautic/developer-documentation#...
Issue(s) addressed Fixes #...

Description:

When creating a focus item, you have this option to decide whether the item should try again with the same user, at another time, if the user already has converted the first time.
This PR changes the action to a positive question.

Before: Stop engaging after a conversion?
After: Engage again after a conversion?

Steps to test this PR:

  1. Open this PR on Gitpod or pull down for testing locally (see docs on testing PRs here)
  2. Open Channels > Focus items > New > Builder
  3. Select the type "Collect data" and see the new label

image

@andersonjeccel andersonjeccel self-assigned this Apr 9, 2024
@andersonjeccel andersonjeccel marked this pull request as draft April 9, 2024 12:59
@andersonjeccel
Copy link
Contributor Author

@mallezie @LordRembo
I think this PR needs logic modification too

@andersonjeccel andersonjeccel added user-experience Anything related to related to workflows, feedback, and navigation enhancement Any improvement to an existing feature or functionality T1 Low difficulty to fix (issue) or test (PR) WIP PR's that are not ready for review and are currently in progress focus-items Anything related to focus items labels Apr 9, 2024
@LordRembo
Copy link
Contributor

Similarly to another PR, see if you it helps to reverse the data condition in plugins/MauticFocusBundle/Form/Type/PropertiesType.php

'data'  => $options['data']['stop_after_conversion'] ? false : true,

@kuzmany
Copy link
Member

kuzmany commented Apr 9, 2024

@LordRembo @andersonjeccel It needs to create a migration too. Is it worth spending that time on that?

@andersonjeccel
Copy link
Contributor Author

@kuzmany It's really out of my knowledge area, so if it's complex, I can close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any improvement to an existing feature or functionality focus-items Anything related to focus items T1 Low difficulty to fix (issue) or test (PR) user-experience Anything related to related to workflows, feedback, and navigation WIP PR's that are not ready for review and are currently in progress
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants