Remove uses of reduce/spread which causes significant latency to large middlewares #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @dimatill, any chance you've had a moment to look over this change? |
|
wow, @ryanquinn3 this is a great finding! Thank you! |
dimatill
requested changes
Jul 7, 2023
src/applicator.ts
Outdated
Comment on lines
154
to
159
| (resolvers, fieldName) => { | ||
| resolvers[fieldName] = applyMiddlewareToField( | ||
| fieldMap[field], | ||
| options, | ||
| middleware[field], | ||
| ), | ||
| }), | ||
| ); |
There was a problem hiding this comment.
Cannot find name 'field'. Could you please rename fieldName back to field, or use fieldName inside the function?
|
@dimatill This is what I get for submitting the PR via github's web editor 😞 Commit pushed. I've confirmed that the package builds & tests pass. |
|
Thank you @ryanquinn3 !!! |
|
🎉 This PR is included in version 6.1.35 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, at work we have a very large graphql schema and use graphql middlewares heavily. I've recently been debugging why our graphql server takes so long to start up and identified one area in this library that contributes a good chunk of that time.
I found that this library performs quite poorly when a particular middleware contains a lot (~1k+) of keys. After a deeper inspection, I see that applicator.ts uses the reduce/spread anti-pattern which I have been bitten by a few times in the last handful of years. The simple changes in this PR should not change the behavior of this library at all but they did reduce the total latency of our
applyMiddlewarecall from ~11s to about 6s. If others in the community are using this library with large schemas & middlewares then I want them to benefit as well.