Remove uses of reduce/spread which causes significant latency to larg…

…e middlewares (#567)
maticzav · Jul 7, 2023 · e9eac82 · e9eac82
1 parent 63d6879
commit e9eac82
Showing 1 changed file with 26 additions and 27 deletions.
diff --git a/src/applicator.ts b/src/applicator.ts
@@ -45,11 +45,10 @@ function parseField(
 ) {
   const { isDeprecated, ...restData } = field
   const argsMap = field.args.reduce(
-    (acc, cur) => ({
-      ...acc,
-      [cur.name]: cur,
-    }),
-    {} as Record<string, GraphQLArgument>,
+    (acc, cur) => {
+      acc[cur.name] = cur;
+      return acc;
+    }, {} as Record<string, GraphQLArgument>,
   )
   return {
     ...restData,
@@ -138,28 +137,28 @@ function applyMiddlewareToType<TSource, TContext, TArgs>(
 
   if (isMiddlewareFunction(middleware)) {
     const resolvers = Object.keys(fieldMap).reduce(
-      (resolvers, fieldName) => ({
-        ...resolvers,
-        [fieldName]: applyMiddlewareToField(
+      (resolvers, fieldName) => {
+        resolvers[fieldName] = applyMiddlewareToField(
           fieldMap[fieldName],
           options,
           middleware as IMiddlewareFunction<TSource, TContext, TArgs>,
-        ),
-      }),
+        );
+        return resolvers;
+      },
       {},
     )
 
     return resolvers
   } else {
     const resolvers = Object.keys(middleware).reduce(
-      (resolvers, field) => ({
-        ...resolvers,
-        [field]: applyMiddlewareToField(
-          fieldMap[field],
+      (resolvers, fieldName) => {
+        resolvers[fieldName] = applyMiddlewareToField(
+          fieldMap[fieldName],
           options,
-          middleware[field],
-        ),
-      }),
+          middleware[fieldName],
+        );
+        return resolvers;
+      },
       {},
     )
 
@@ -181,14 +180,14 @@ function applyMiddlewareToSchema<TSource, TContext, TArgs>(
         !isIntrospectionType(typeMap[type]),
     )
     .reduce(
-      (resolvers, type) => ({
-        ...resolvers,
-        [type]: applyMiddlewareToType(
+      (resolvers, type) => {
+        resolvers[type] = applyMiddlewareToType(
           typeMap[type] as GraphQLObjectType,
           options,
           middleware,
-        ),
-      }),
+        );
+        return resolvers;
+      },
       {},
     )
 
@@ -216,14 +215,14 @@ export function generateResolverFromSchemaAndMiddleware<
     const typeMap = schema.getTypeMap()
 
     const resolvers = Object.keys(middleware).reduce(
-      (resolvers, type) => ({
-        ...resolvers,
-        [type]: applyMiddlewareToType(
+      (resolvers, type) => {
+        resolvers[type] = applyMiddlewareToType(
           typeMap[type] as GraphQLObjectType,
           options,
           middleware[type],
-        ),
-      }),
+        );
+        return resolvers;
+      },
       {},
     )