Add support for MSW #68
Conversation
djhi
added
RFR
README.md
Outdated
| ReactDom.render(<App />, document.getElementById("root")); | ||
| }); | ||
| ``` | ||
|
|
||
| ### Fake XMLHTTPRequest |
There was a problem hiding this comment.
I'd frename that one Sinon, and the following fetchMock
| type BaseRequest = { | ||
| url?: string; | ||
| method?: string; | ||
| requestJson?: Record<string, any> | undefined; |
There was a problem hiding this comment.
Not sure what requestJson means. Isn't it the body?
There was a problem hiding this comment.
I kept the old code to avoid renaming too many things. You should remember! ;)
src/msw.ts
Outdated
There was a problem hiding this comment.
The file name doesn't follow the same convention as other adapters
There was a problem hiding this comment.
How so? There's only one other adapter which is named fetchMock
public/mockServiceWorker.js
Outdated
There was a problem hiding this comment.
I don't understand what this file does here. It's included nowhere, and it looks autogenerated.
There was a problem hiding this comment.
Autogenerated by MSW installation instructions: https://mswjs.io/docs/integrations/browser
public/sinon.html
Outdated
There was a problem hiding this comment.
Can't you move this file to the example directory?
There was a problem hiding this comment.
Nope, that's we can handle it with vite to avoid bundling. I've not been able to make it work with sinon like I do with the two other adapters
Co-authored-by: Francois Zaninotto <francois@marmelab.com>
fetch-mock,sinonormsw