Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom id generation #69

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Conversation

djhi
Copy link
Contributor

@djhi djhi commented May 3, 2024

Follow #68

  • Support string identifiers
  • Support custom identifier generation

@djhi djhi added the RFR Ready For Review label May 3, 2024
@djhi djhi added this to the 4.0.0 milestone May 3, 2024
@djhi djhi added WIP Work In Progress and removed RFR Ready For Review labels May 3, 2024
@djhi djhi added RFR Ready For Review and removed WIP Work In Progress labels May 3, 2024
Copy link
Member

@fzaninotto fzaninotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rebase now that I've merged the other PR?

import FakeRest from 'fakerest';
import uuid from 'uuid';

const restServer = new FakeRest.Server('http://my.custom.domain', () => uuid.v5());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're in for a breaking change, we can afford changing the signature to a params object. Same for Fakerest.Server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants