Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose scale factor #607

Open
wants to merge 2 commits into
base: feat/react-to-scale-factor-changes
Choose a base branch
from

Conversation

marc2332
Copy link
Owner

@marc2332 marc2332 commented May 9, 2024

Closes #605
Depends on #606

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (feat/react-to-scale-factor-changes@1c75fd3). Click here to learn what that means.

Files Patch % Lines
crates/renderer/src/app.rs 0.00% 4 Missing ⚠️
crates/renderer/src/renderer.rs 0.00% 4 Missing ⚠️
crates/hooks/src/use_platform.rs 71.42% 2 Missing ⚠️
crates/components/src/graph.rs 0.00% 1 Missing ⚠️
crates/renderer/src/elements/rect.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##             feat/react-to-scale-factor-changes     #607   +/-   ##
=====================================================================
  Coverage                                      ?   73.11%           
=====================================================================
  Files                                         ?      190           
  Lines                                         ?    19239           
  Branches                                      ?        0           
=====================================================================
  Hits                                          ?    14067           
  Misses                                        ?     5172           
  Partials                                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marc2332 marc2332 marked this pull request as ready for review May 15, 2024 19:23
@marc2332 marc2332 linked an issue May 16, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🔥 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: Expose scale factor in PlatformInformation
1 participant