Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: Expose scale factor in PlatformInformation #605

Open
ZeroX-DG opened this issue May 9, 2024 · 6 comments · May be fixed by #607
Open

enhancement: Expose scale factor in PlatformInformation #605

ZeroX-DG opened this issue May 9, 2024 · 6 comments · May be fixed by #607
Assignees
@marc2332
Labels
enhancement 🔥 New feature or request

Comments

@ZeroX-DG
Copy link
Contributor

ZeroX-DG commented May 9, 2024 •
edited

We should expose the window scaling factor as part of PlatformInformation so user can manually do the scaling in their canvas.
@ZeroX-DG
Copy link
Contributor Author

ZeroX-DG commented May 9, 2024

Just realised #270 exist 🤦 I'll rename this.

@ZeroX-DG ZeroX-DG changed the title Rescale UI when scaling factor changed Expose scale factor in PlatformInformation May 9, 2024
@marc2332
Copy link
Owner

marc2332 commented May 9, 2024

Yeah, I actually tried to get automatic scale factor to work a while ago, but I couldn't make it work, worth revisiting

@marc2332
Copy link
Owner

marc2332 commented May 9, 2024

Yeah, exposing the scale factor is definitely a good idea, shouldn't be too hard either

@marc2332 marc2332 added the enhancement 🔥 New feature or request label May 9, 2024
@marc2332 marc2332 changed the title Expose scale factor in PlatformInformation enhancement: Expose scale factor in PlatformInformation May 9, 2024
@marc2332
Copy link
Owner

marc2332 commented May 9, 2024

Started working on #606, I'll get it working soon

@marc2332
Copy link
Owner

marc2332 commented May 9, 2024

Can you @ZeroX-DG and see if it now reacts properly when you move it through windows? I have yet to add it to PlatFormInformation tho

@marc2332 marc2332 linked a pull request May 9, 2024 that will close this issue
Open
@marc2332
Copy link
Owner

marc2332 commented May 9, 2024

Just opened #607

@marc2332 marc2332 self-assigned this May 16, 2024
@marc2332 marc2332 linked a pull request May 16, 2024 that will close this issue
feat: Expose scale factor #607
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marc2332 marc2332

Labels
enhancement 🔥 New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Expose scale factor marc2332/freya
2 participants
@ZeroX-DG @marc2332