Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu position #2120

Merged
merged 3 commits into from May 16, 2024
Merged

Fix menu position #2120

merged 3 commits into from May 16, 2024

Conversation

samtygier-stfc
Copy link
Collaborator

@samtygier-stfc samtygier-stfc commented Mar 8, 2024

Issue

Closes #2119

Note, this is waiting on the pyqtgraph 0.13.5 release

Description

Update pyqtgraph to 0.13.7
Set menu position of the Auto option relative to the RGB entry.
Removed index as an argument as it was never used.

Testing & Acceptance Criteria

Update your dev environment

Open a dataset.
Right click on the colour bar by the histogram, and change choose auto.
Should give the auto colour dialog with no errors.

Also check that all the main gui windows (operations, recon, spectrum view) open, and behave normally

Documentation

release notes

@coveralls
Copy link

coveralls commented Mar 8, 2024

Coverage Status

coverage: 72.735% (+0.005%) from 72.73%
when pulling addf052 on 2119-fix-menu-position
into 2a6191e on main.

@samtygier-stfc
Copy link
Collaborator Author

samtygier-stfc commented May 14, 2024

The pyqtgraph update causes some small changes to axis tick locations.
I have updated the baselines
image

@samtygier-stfc samtygier-stfc marked this pull request as ready for review May 14, 2024 16:30
@samtygier-stfc samtygier-stfc added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit aa6025b May 16, 2024
8 checks passed
@samtygier-stfc samtygier-stfc deleted the 2119-fix-menu-position branch May 16, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyQtGraph colour menu changes upset adding the Auto action
3 participants