-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyQtGraph colour menu changes upset adding the Auto action #2119
Comments
First part of the fix is changing our code to not assume that 12 is a good position to add the new item. Second part depends on a fix in pyqtgraph |
I'll be merging #2955 in short order, I had a nit-picky thing regarding the docs which I'm going to address, but been busy non-pyqtgraph work 😬 Given the breakages that that PR addresses, I'll likely cut another pyqtgraph release shortly after. |
@j9ac9k great thank you. |
Summary
There is a change in PyQtGraph between 0.13.3 and 0.13.4 in the colourbar context menu.
We currently insert the "Auto" item in the 12 position, but now that the menu is shorter this triggers a
IndexError: list index out of range
The old menu looked like
The new menu (with adding the Auto item)
Steps To Reproduce
Update pyqtgraph
mamba install pyqtgraph=0.13.4
Open a dataset and right click on the colour bar
Expected Behaviour
Menu to choose colours, with the Auto item
Current Behaviour
IndexError: list index out of range
Context
Current main.
Our conda/meta.yaml has
pyqtgraph=0.13.*
so we started picking up the new version today.Failure Logs
The text was updated successfully, but these errors were encountered: