Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in gd_prtn_chrg for chunked data #18891

Merged
merged 5 commits into from Feb 17, 2017

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Feb 16, 2017

There was a bug in the gd_prtn_chrg if the data was processed with chunking. Adding a call to wksp.run().integrateProtonCharge() before NormaliseByCurrent fixes the issue since it forces the workspace to re-integrate the proton charge based on the logs.

To test:

Process a dataset with chunking.

There is no associated issue

This does not have release notes because it the patch release needs to be setup and hasn't been yet.


Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests
  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@peterfpeterson peterfpeterson added Diffraction Issues and pull requests related to diffraction Powder Issues and pull requests related to powder diffraction Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Patch Candidate Urgent issues that must be included in a patch following a release labels Feb 16, 2017
@peterfpeterson peterfpeterson added this to the Release 3.10 milestone Feb 16, 2017
@wdzhou
Copy link
Collaborator

wdzhou commented Feb 17, 2017

I did test by running an auto reduction script of a recent run. The corrected code can generate the reduced data consistent with different max chunk size, while the previous code cannot. So the bug is well resolved.

It is based from release 3.9. And the failure of Flake8 seems not to be caused by the change of this PR.

:shipit:

@AndreiSavici AndreiSavici merged commit 70113cf into release-v3.9 Feb 17, 2017
@AndreiSavici AndreiSavici deleted the SNSPowderReduction_pcharge_fix branch February 17, 2017 15:58
@rosswhitfield
Copy link
Member

This has broken the performance tests http://builds.mantidproject.org/job/master_performancetests/3934/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Diffraction Issues and pull requests related to diffraction Patch Candidate Urgent issues that must be included in a patch following a release Powder Issues and pull requests related to powder diffraction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants