Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing parameter in function call #18915

Merged
merged 1 commit into from Feb 17, 2017
Merged

Add missing parameter in function call #18915

merged 1 commit into from Feb 17, 2017

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Feb 17, 2017 •
edited

Fixed the bug that @rosswhitfield identified as being introduced here to the NormaliseByCurrent performance test.

To test:

Try running it and see if ctest -R NormaliseByCurrentTest works.

This addresses the bug introduced in #18891 .

Does not need to be in the release notes.

Reviewer

Please comment on the following (full description):

Code Review
  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
  • Are there unit/system tests in place? Are the unit tests small and test the a class in isolation?
  • If there are changes in the release notes then do they describe the changes appropriately?
Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?

  • How do the changes handle unexpected situations, e.g. bad input?

  • Has the relevant documentation been added/updated?

  • Is user-facing documentation written in a user-friendly manner?

  • Has developer documentation been updated if required?

  • Does everything look good? Comment with the ship it emoji but don't merge. A member of @mantidproject/gatekeepers will take care of it.

@peterfpeterson peterfpeterson added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release. labels Feb 17, 2017
@peterfpeterson peterfpeterson added this to the Release 3.10 milestone Feb 17, 2017
@rosswhitfield rosswhitfield self-assigned this Feb 17, 2017
@rosswhitfield
Copy link
Member

AlgorithmsTest_NormaliseByCurrentTestPerformance now passes. :shipit: once the builds pass.

@peterfpeterson peterfpeterson added the Patch Candidate Urgent issues that must be included in a patch following a release label Feb 17, 2017
@AndreiSavici AndreiSavici merged commit fa5a376 into master Feb 17, 2017
@AndreiSavici AndreiSavici deleted the norm_pcharge_performace branch February 17, 2017 20:46
martyngigg added a commit that referenced this pull request Feb 23, 2017
@martyngigg
Cherry-pick pull request #18915
1210167 
Add missing parameter in function call

(cherry picked from commit c0920c0)

Added patch release note.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rosswhitfield rosswhitfield

Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Patch Candidate Urgent issues that must be included in a patch following a release
Projects
None yet
Milestone
Release 3.9.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterfpeterson @rosswhitfield @martyngigg @AndreiSavici