Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISISEnergyTransferPresenter is a QObject #37086

Open
robertapplin opened this issue Mar 27, 2024 · 0 comments · May be fixed by #37227
Open

ISISEnergyTransferPresenter is a QObject #37086

robertapplin opened this issue Mar 27, 2024 · 0 comments · May be fixed by #37227
Assignees
@robertapplin
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Milestone
Release 6.11

Comments

@robertapplin
Copy link
Contributor

Describe the outcome that is desired.
The ISISEnergyTransferPresenter class is a QObject we want to refactor this class so it no longer depends on Qt. We should make sure that when we convert the remaining Data Reduction tabs to MVP, that their presenters are not QObjects.

Acceptance criteria

  • ISISEnergyTransferPresenter is no longer a QObject
@robertapplin robertapplin added Indirect/Inelastic Issues and pull requests related to indirect or inelastic Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS labels Mar 27, 2024
@robertapplin robertapplin mentioned this issue Mar 27, 2024
Merged
@robertapplin robertapplin self-assigned this Apr 25, 2024
@robertapplin robertapplin linked a pull request Apr 26, 2024 that will close this issue
Open
@robertapplin robertapplin added this to the Release 6.11 milestone May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertapplin robertapplin

Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
ISIS Spectroscopy
Status: In Progress
Milestone
Release 6.11
Development

Successfully merging a pull request may close this issue.

ISISEnergyTransferPresenter no longer a QObject robertapplin/mantid
1 participant
@robertapplin