ISISEnergyTransferPresenter no longer a QObject #37227
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertapplin
added
Indirect/Inelastic
robertapplin
force-pushed
the
37086-iet-presenter-is-qobject
branch
from
e924c35
to
70c13f7
Compare
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @robertapplin, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
robertapplin
force-pushed
the
37086-iet-presenter-is-qobject
branch
2 times, most recently
from
a5b8127
to
9e1da16
Compare
robertapplin
removed
the
Has Conflicts
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @robertapplin, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
robertapplin
force-pushed
the
37086-iet-presenter-is-qobject
branch
from
9e1da16
to
c41ce6a
Compare
robertapplin
removed
the
Has Conflicts
robertapplin
force-pushed
the
37086-iet-presenter-is-qobject
branch
2 times, most recently
from
5acf1cd
to
fdb3fef
Compare
robertapplin
force-pushed
the
37086-iet-presenter-is-qobject
branch
from
fdb3fef
to
9f77f5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This PR does some refactoring of the ISISEnergyTransferPresenter so that it is no longer a QObject. It now uses the
AlgorithmRunnerclass to run the algorithms in a background thread rather than the BatchAlgorithmRunner Qt object.Fixes #37086
To test:
Follow the instructions on this page
https://developer.mantidproject.org/Testing/Indirect/DataReductionTests.html
This does not require release notes because its an internal change
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.