New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ISISEnergyTransferPresenterTest #37044
Enable ISISEnergyTransferPresenterTest #37044
Conversation
37f6925
to
8b21cbe
Compare
👋 Hi, @robertapplin, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
7fe2011
to
6814158
Compare
fae7693
to
bec9baf
Compare
👋 Hi, @robertapplin, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
…leak when attempting to delete mock objects
bec9baf
to
22927c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with testing instructions. Everything is working fine, and it would be a good change for easier testing of these classes. I haven't spotted any problem.
Description of work
This PR makes it possible to test the ISISEnergyTransferPresenter by creating interface classes for the model and view which can be used for mocking, and also interface classes for the IndirectDataReduction class. This has allowed me to enable the ISISEnergyTransferPresenterTest and write some new tests for this class.
Fixes #36897
To test:
Code review, make sure the
ISISEnergyTransferPresenterTest
is running in our CI.Follow the testing instructions here:
https://developer.mantidproject.org/Testing/Indirect/DataReductionTests.html
This does not require release notes because it is an internal change
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.