Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ISISEnergyTransferPresenterTest #37044

Merged

Conversation

robertapplin
Copy link
Contributor

@robertapplin robertapplin commented Mar 19, 2024

Description of work

This PR makes it possible to test the ISISEnergyTransferPresenter by creating interface classes for the model and view which can be used for mocking, and also interface classes for the IndirectDataReduction class. This has allowed me to enable the ISISEnergyTransferPresenterTest and write some new tests for this class.

Fixes #36897

To test:

Code review, make sure the ISISEnergyTransferPresenterTest is running in our CI.

Follow the testing instructions here:
https://developer.mantidproject.org/Testing/Indirect/DataReductionTests.html

This does not require release notes because it is an internal change

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@robertapplin robertapplin added Indirect/Inelastic Issues and pull requests related to indirect or inelastic Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS labels Mar 19, 2024
@robertapplin robertapplin added this to the Release 6.10 milestone Mar 19, 2024
@robertapplin robertapplin force-pushed the 36897-energy-transfer-tab-mvp branch 2 times, most recently from 37f6925 to 8b21cbe Compare March 20, 2024 12:25
Copy link

👋 Hi, @robertapplin,

Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

@github-actions github-actions bot added the Has Conflicts Used by the bot to label pull requests that have conflicts label Mar 20, 2024
@robertapplin robertapplin removed the Has Conflicts Used by the bot to label pull requests that have conflicts label Mar 20, 2024
@robertapplin robertapplin force-pushed the 36897-energy-transfer-tab-mvp branch 3 times, most recently from fae7693 to bec9baf Compare March 21, 2024 08:58
@robertapplin robertapplin marked this pull request as ready for review March 21, 2024 12:01
@adriazalvarez adriazalvarez self-assigned this Mar 27, 2024
@github-actions github-actions bot added the Has Conflicts Used by the bot to label pull requests that have conflicts label Mar 27, 2024
Copy link

👋 Hi, @robertapplin,

Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

@robertapplin robertapplin removed the Has Conflicts Used by the bot to label pull requests that have conflicts label Mar 27, 2024
Copy link
Contributor

@adriazalvarez adriazalvarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with testing instructions. Everything is working fine, and it would be a good change for easier testing of these classes. I haven't spotted any problem.

@SilkeSchomann SilkeSchomann merged commit e65c80c into mantidproject:main Mar 27, 2024
9 checks passed
@robertapplin robertapplin deleted the 36897-energy-transfer-tab-mvp branch May 17, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

ISISEnergyTransferPresenterTest is not being run
3 participants