Example implementation of enumerate #1386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willdealtry
force-pushed
the
enumerate
branch
from
ee5bbba
to
90770ed
Compare
5 tasks
willdealtry
force-pushed
the
enumerate
branch
from
90770ed
to
fd4369f
Compare
|
|
||
| class Proxy { | ||
| public: | ||
| using difference_type = ssize_t; |
There was a problem hiding this comment.
What is difference_type supposed to represent? Is it difference between Enumerator::idx_? If so it seems a bit dangerous as idx_ is of unsigned type.
| #include <arcticdb/log/log.hpp> | ||
|
|
||
| TEST(Enumerate, Vector) { | ||
| std::vector<int> vec = {1, 2, 3, 4}; |
There was a problem hiding this comment.
nit: static constexpr std::array = {1,2,3,4}
| @@ -0,0 +1,119 @@ | |||
| #pragma once | |||
IvoDD
added a commit
that referenced
this pull request
Mar 22, 2024
Introduces a new type LoadStrategy which has the load_type, the include_deleted boolean and the version/time we need to search for. With this commit we mostly preserve existing behavior with a few exceptions: - The newly introduced deleted/undeleted variants of LOAD_DOWNTO and LOAD_FROM_TIME are introduced and are handled appropriately and their behavior is documented in LoadStrategy. - Abstract away the batch version map merging of LoadStrategies and fix a small bug there. - Fixes #1386 by passing include_deleted=false when looking for as_of time or version
IvoDD
added a commit
that referenced
this pull request
Mar 26, 2024
Introduces a new type LoadStrategy which has the load_type, the include_deleted boolean and the version/time we need to search for. With this commit we mostly preserve existing behavior with a few exceptions: - The newly introduced deleted/undeleted variants of LOAD_DOWNTO and LOAD_FROM_TIME are introduced and are handled appropriately and their behavior is documented in LoadStrategy. - Abstract away the batch version map merging of LoadStrategies and fix a small bug there. - Fixes #1386 by passing include_deleted=false when looking for as_of time or version Also adds an elaborate FollowingVersionChain cpp test
IvoDD
added a commit
that referenced
this pull request
Mar 26, 2024
Introduces a new type LoadStrategy which has the load_type, the include_deleted boolean and the version/time we need to search for. With this commit we mostly preserve existing behavior with a few exceptions: - The newly introduced deleted/undeleted variants of LOAD_DOWNTO and LOAD_FROM_TIME are introduced and are handled appropriately and their behavior is documented in LoadStrategy. - Abstract away the batch version map merging of LoadStrategies and fix a small bug there. - Fixes #1386 by passing include_deleted=false when looking for as_of time or version Also adds an elaborate FollowingVersionChain cpp test
IvoDD
added a commit
that referenced
this pull request
Mar 26, 2024
Introduces a new type LoadStrategy which has the load_type, the include_deleted boolean and the version/time we need to search for. With this commit we mostly preserve existing behavior with a few exceptions: - The newly introduced deleted/undeleted variants of LOAD_DOWNTO and LOAD_FROM_TIME are introduced and are handled appropriately and their behavior is documented in LoadStrategy. - Abstract away the batch version map merging of LoadStrategies and fix a small bug there. - Fixes #1386 by passing include_deleted=false when looking for as_of time or version Also adds an elaborate FollowingVersionChain cpp test
IvoDD
added a commit
that referenced
this pull request
Mar 27, 2024
Introduces a new type LoadStrategy which has the load_type, the include_deleted boolean and the version/time we need to search for. With this commit we mostly preserve existing behavior with a few exceptions: - The newly introduced deleted/undeleted variants of LOAD_DOWNTO and LOAD_FROM_TIME are introduced and are handled appropriately and their behavior is documented in LoadStrategy. - Abstract away the batch version map merging of LoadStrategies and fix a small bug there. - Fixes #1386 by passing include_deleted=false when looking for as_of time or version Also adds an elaborate FollowingVersionChain cpp test
IvoDD
added a commit
that referenced
this pull request
Apr 16, 2024
Introduces a new type LoadStrategy which has the load_type, the include_deleted boolean and the version/time we need to search for. With this commit we mostly preserve existing behavior with a few exceptions: - The newly introduced deleted/undeleted variants of LOAD_DOWNTO and LOAD_FROM_TIME are introduced and are handled appropriately and their behavior is documented in LoadStrategy. - Abstract away the batch version map merging of LoadStrategies and fix a small bug there. - Fixes #1386 by passing include_deleted=false when looking for as_of time or version Also adds an elaborate FollowingVersionChain cpp test
IvoDD
added a commit
that referenced
this pull request
Apr 17, 2024
Introduces a new type LoadStrategy which has the load_type, the to_load enum, which indicates whether to load ANY or only UNDELETED versions and the version/time we need to search for. With this commit we mostly preserve existing behavior with a few exceptions: - The newly introduced deleted/undeleted variants of LOAD_DOWNTO and LOAD_FROM_TIME are introduced and are handled appropriately and their behavior is documented in LoadStrategy. - Abstract away the batch version map merging of LoadStrategies and fix a small bug there. - Fixes #1386 by passing include_deleted=false when looking for as_of time or version Also adds an elaborate FollowingVersionChain cpp test
IvoDD
added a commit
that referenced
this pull request
Apr 18, 2024
Introduces a new type LoadStrategy which has the load_type, the to_load enum, which indicates whether to load ANY or only UNDELETED versions and the version/time we need to search for. With this commit we mostly preserve existing behavior with a few exceptions: - The newly introduced deleted/undeleted variants of LOAD_DOWNTO and LOAD_FROM_TIME are introduced and are handled appropriately and their behavior is documented in LoadStrategy. - Abstract away the batch version map merging of LoadStrategies and fix a small bug there. - Fixes #1386 by passing include_deleted=false when looking for as_of time or version Also adds an elaborate FollowingVersionChain and FollowingVersionChainWithCaching cpp tests
IvoDD
added a commit
that referenced
this pull request
Apr 18, 2024
Introduces a new type LoadStrategy which has the load_type, the to_load enum, which indicates whether to load ANY or only UNDELETED versions and the version/time we need to search for. With this commit we mostly preserve existing behavior with a few exceptions: - The newly introduced deleted/undeleted variants of LOAD_DOWNTO and LOAD_FROM_TIME are introduced and are handled appropriately and their behavior is documented in LoadStrategy. - Abstract away the batch version map merging of LoadStrategies and fix a small bug there. - Fixes #1386 by passing include_deleted=false when looking for as_of time or version Also adds an elaborate FollowingVersionChain and FollowingVersionChainWithCaching cpp tests
IvoDD
added a commit
that referenced
this pull request
Apr 18, 2024
Introduces a new type LoadStrategy which has the load_type, the to_load enum, which indicates whether to load ANY or only UNDELETED versions and the version/time we need to search for. With this commit we mostly preserve existing behavior with a few exceptions: - The newly introduced deleted/undeleted variants of LOAD_DOWNTO and LOAD_FROM_TIME are introduced and are handled appropriately and their behavior is documented in LoadStrategy. - Abstract away the batch version map merging of LoadStrategies and fix a small bug there. - Fixes #1386 by passing include_deleted=false when looking for as_of time or version Also adds an elaborate FollowingVersionChain and FollowingVersionChainWithCaching cpp tests
IvoDD
added a commit
that referenced
this pull request
Apr 24, 2024
Introduces a new type LoadStrategy which has the load_type, the to_load enum, which indicates whether to load ANY or only UNDELETED versions and the version/time we need to search for. With this commit we mostly preserve existing behavior with a few exceptions: - The newly introduced deleted/undeleted variants of LOAD_DOWNTO and LOAD_FROM_TIME are introduced and are handled appropriately and their behavior is documented in LoadStrategy. - Abstract away the batch version map merging of LoadStrategies and fix a small bug there. - Fixes #1386 by passing include_deleted=false when looking for as_of time or version Also adds an elaborate FollowingVersionChain and FollowingVersionChainWithCaching cpp tests
IvoDD
added a commit
that referenced
this pull request
May 21, 2024
Introduces a new type LoadStrategy which has the load_type, the to_load enum, which indicates whether to load ANY or only UNDELETED versions and the version/time we need to search for. With this commit we mostly preserve existing behavior with a few exceptions: - The newly introduced deleted/undeleted variants of LOAD_DOWNTO and LOAD_FROM_TIME are introduced and are handled appropriately and their behavior is documented in LoadStrategy. - Abstract away the batch version map merging of LoadStrategies and fix a small bug there. - Fixes #1386 by passing include_deleted=false when looking for as_of time or version Also adds an elaborate FollowingVersionChain and FollowingVersionChainWithCaching cpp tests
IvoDD
added a commit
that referenced
this pull request
May 21, 2024
Introduces a new type LoadStrategy which has the load_type, the to_load enum, which indicates whether to load ANY or only UNDELETED versions and the version/time we need to search for. With this commit we mostly preserve existing behavior with a few exceptions: - The newly introduced deleted/undeleted variants of LOAD_DOWNTO and LOAD_FROM_TIME are introduced and are handled appropriately and their behavior is documented in LoadStrategy. - Abstract away the batch version map merging of LoadStrategies and fix a small bug there. - Fixes #1386 by passing include_deleted=false when looking for as_of time or version Also adds an elaborate FollowingVersionChain and FollowingVersionChainWithCaching cpp tests
IvoDD
added a commit
that referenced
this pull request
May 23, 2024
Introduces a new type LoadStrategy which has the load_type, the to_load enum, which indicates whether to load ANY or only UNDELETED versions and the version/time we need to search for. With this commit we mostly preserve existing behavior with a few exceptions: - The newly introduced deleted/undeleted variants of LOAD_DOWNTO and LOAD_FROM_TIME are introduced and are handled appropriately and their behavior is documented in LoadStrategy. - Abstract away the batch version map merging of LoadStrategies and fix a small bug there. - Fixes #1386 by passing include_deleted=false when looking for as_of time or version Also adds an elaborate FollowingVersionChain and FollowingVersionChainWithCaching cpp tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of internal implementation of enumerate