Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Remove usage of folly::enumerate #1376

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jjerphan
Copy link
Collaborator

Reference Issues/PRs

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@jjerphan jjerphan force-pushed the maint/remove-folly-enumerate-usages branch from c241a4c to 5a5dbdd Compare February 28, 2024 07:36
@willdealtry
Copy link
Collaborator

willdealtry commented Feb 29, 2024

This is a very trivial class to implement. Might it not be better to just have our own version rather than making such significant changes across the codebase? #1386

We can credit folly with the original implementation, but there's really not much to it, and not really many other ways to do accomplish it, and it does add significant clarity to the code in certain circumstances

@jjerphan
Copy link
Collaborator Author

jjerphan commented Mar 1, 2024

This is a very trivial class to implement. Might it not be better to just have our own version rather than making such significant changes across the codebase? #1386

Yes, definitely (this PR is still a draft and I switched to some other tasks). I was just trying to see if a simple entire removal of the header was possible, but we definitely need to add some syntactic sugar as proposed by #1386.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
@jjerphan jjerphan force-pushed the maint/remove-folly-enumerate-usages branch from 5a5dbdd to 0e84712 Compare March 8, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants