Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hex Strings #234

Merged
merged 10 commits into from Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions lorawan-encoding/Cargo.toml
Expand Up @@ -13,6 +13,7 @@ readme = "README.md"
aes = { version = "0.8", optional = true }
cmac = { version = "0.7", optional = true }
generic-array = "0"
hex = { version = "0", default-features = false }
defmt = { version = "0.3", optional = true }
serde = { version = "1", default-features = false, features = ["derive"], optional = true}

Expand Down
2 changes: 0 additions & 2 deletions lorawan-encoding/src/extra/mod.rs
Expand Up @@ -9,5 +9,3 @@
pub extern crate std;

pub mod hasher;
#[cfg(feature = "with-to-string")]
pub mod to_string;
54 changes: 0 additions & 54 deletions lorawan-encoding/src/extra/to_string.rs

This file was deleted.

16 changes: 14 additions & 2 deletions lorawan-encoding/src/keys.rs
Expand Up @@ -31,12 +31,18 @@ macro_rules! lorawan_key {
}
}

};
}
impl AsRef<[u8]> for $type {
fn as_ref(&self) -> &[u8] {
&self.0 .0
}
}
};
}

lorawan_key!(
/// AppKey should be entered in MSB format. For example, if your LNS provides a AppKey of
/// `00:11:22:33:44:55:66:77:88:99:AA:BB:CC:DD:EE:FF`, you should enter it as `AppKey([0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77, 0x88, 0x99, 0xAA, 0xBB, 0xCC, 0xDD, 0xEE, 0xFF])`.
/// Alternatively, you can use the from_str method
pub struct AppKey(AES128);
);
lorawan_key!(
Expand Down Expand Up @@ -72,6 +78,12 @@ macro_rules! lorawan_eui {
key.0
}
}

impl AsRef<[u8]> for $type {
fn as_ref(&self) -> &[u8] {
&self.0.as_ref()
}
}
};
}

Expand Down
1 change: 1 addition & 0 deletions lorawan-encoding/src/lib.rs
Expand Up @@ -17,6 +17,7 @@ pub mod maccommandcreator;
pub mod maccommands;
pub mod packet_length;
pub mod parser;
pub mod string;

#[cfg(feature = "full")]
pub mod extra;
Expand Down
168 changes: 168 additions & 0 deletions lorawan-encoding/src/string.rs
@@ -0,0 +1,168 @@
use crate::keys::*;
use crate::parser::*;

#[cfg(feature = "with-to-string")]
pub extern crate std;

pub use hex::FromHexError;

macro_rules! fixed_len_struct_impl_to_string_msb {
(
$type:ident,$size:expr;
) => {
impl core::str::FromStr for $type {
type Err = FromHexError;

fn from_str(s: &str) -> Result<Self, Self::Err> {
let mut res = [0; $size];
hex::decode_to_slice(s.as_bytes(), &mut res)?;
Ok(Self::from(res))
}
}

#[cfg(feature = "with-to-string")]
impl std::string::ToString for $type {
fn to_string(&self) -> std::string::String {
let mut res = std::string::String::with_capacity($size * 2);
res.extend(std::iter::repeat('-').take($size * 2));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why -?
Is there a test with under- and oversized hex string?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never assert size, but the - ensure an unwritten char would be obvious.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concerning missized strings, good point! I'll work on that now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hex library handles them nicely it seems

let slice = unsafe { &mut res.as_bytes_mut() };
hex::encode_to_slice(self.as_ref(), slice).unwrap();
res
}
}
};
(
$type:ident[$size:expr];
) => {
impl core::str::FromStr for $type<[u8; $size]> {
type Err = FromHexError;

fn from_str(s: &str) -> Result<Self, Self::Err> {
let mut res = [0; $size];
hex::decode_to_slice(s.as_bytes(), &mut res)?;
Ok(Self::from(res))
}
}

#[cfg(feature = "with-to-string")]
impl<T: AsRef<[u8]>> std::string::ToString for $type<T> {
fn to_string(&self) -> std::string::String {
let mut res = std::string::String::with_capacity($size * 2);
res.extend(std::iter::repeat('-').take($size * 2));
let slice = unsafe { &mut res.as_bytes_mut() };
hex::encode_to_slice(self.as_ref(), slice).unwrap();
res
}
}
};
}

macro_rules! fixed_len_struct_impl_string_lsb {
(
$type:ident,$size:expr;
) => {
impl core::str::FromStr for $type {
type Err = FromHexError;

fn from_str(s: &str) -> Result<Self, Self::Err> {
let mut res = [0; $size];
hex::decode_to_slice(s.as_bytes(), &mut res)?;
res.reverse();
Ok(Self::from(res))
}
}

#[cfg(feature = "with-to-string")]
impl std::string::ToString for $type {
fn to_string(&self) -> std::string::String {
let mut res = std::string::String::with_capacity($size * 2);
res.extend(std::iter::repeat('0').take($size * 2));
let slice = unsafe { &mut res.as_bytes_mut() };
self.as_ref().iter().rev().enumerate().for_each(|(i, b)| {
hex::encode_to_slice(&[*b], &mut slice[i * 2..i * 2 + 2]).unwrap();
});
res
}
}
};
}

fixed_len_struct_impl_to_string_msb! {
EUI64[8];
}

fixed_len_struct_impl_to_string_msb! {
DevNonce[2];
}

fixed_len_struct_impl_to_string_msb! {
AppNonce[3];
}

fixed_len_struct_impl_to_string_msb! {
DevAddr[4];
}

fixed_len_struct_impl_to_string_msb! {
NwkAddr[3];
}

fixed_len_struct_impl_to_string_msb! {
AppKey, 16;
}

fixed_len_struct_impl_to_string_msb! {
NewSKey, 16;
}

fixed_len_struct_impl_to_string_msb! {
AppSKey, 16;
}

fixed_len_struct_impl_string_lsb! {
DevEui, 8;
}

fixed_len_struct_impl_string_lsb! {
AppEui, 8;
}

#[cfg(test)]
mod test {
use super::*;
use crate::extra::std::string::ToString;
use core::str::FromStr;

#[test]
fn test_appskey_to_string() {
let appskey = AppSKey::from([
0x01, 0x23, 0x45, 0x67, 0x89, 0xab, 0xcd, 0xef, 0xfd, 0xb9, 0x75, 0x31, 0x24, 0x68,
0xac, 0xed,
]);
assert_eq!(appskey.to_string(), "0123456789abcdeffdb975312468aced");
}

#[test]
fn test_appskey_from_str() {
let appskey = AppSKey::from_str("00112233445566778899aabbccddeeff").unwrap();
assert_eq!(
appskey,
AppSKey::from([
0x00, 0x11, 0x22, 0x33, 0x44, 0x55, 0x66, 0x77, 0x88, 0x99, 0xAA, 0xBB, 0xCC, 0xDD,
0xEE, 0xFF
])
);
}

#[test]
fn test_deveui_to_string() {
let deveui = DevEui::from([0xf0, 0xde, 0xbc, 0x9a, 0x78, 0x56, 0x34, 0x12]);
assert_eq!(deveui.to_string(), "123456789abcdef0");
}

#[test]
fn test_deveui_from_str() {
let deveui = DevEui::from_str("123456789abcdef0").unwrap();
assert_eq!(deveui, DevEui::from([0xf0, 0xde, 0xbc, 0x9a, 0x78, 0x56, 0x34, 0x12]));
}
}