Hex Strings #234
Merged
Hex Strings #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plaes
previously approved these changes
Mar 27, 2024
|
You may also want to revise copyright strings... |
lucasgranberg
previously approved these changes
Mar 27, 2024
|
On second though, I realized feature-gating from_str was not terribly useful, so I've reorganized things so that from_str is always available. |
plaes
reviewed
Mar 27, 2024
| impl std::string::ToString for $type { | ||
| fn to_string(&self) -> std::string::String { | ||
| let mut res = std::string::String::with_capacity($size * 2); | ||
| res.extend(std::iter::repeat('-').take($size * 2)); |
There was a problem hiding this comment.
Why -?
Is there a test with under- and oversized hex string?
There was a problem hiding this comment.
We never assert size, but the - ensure an unwritten char would be obvious.
There was a problem hiding this comment.
Concerning missized strings, good point! I'll work on that now
There was a problem hiding this comment.
The hex library handles them nicely it seems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.