Skip to content

Release Connection on Error- Changing statement order #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Release Connection on Error- Changing statement order #215

wants to merge 1 commit into from

Conversation

@sk222
Copy link

@sk222 sk222 commented Jul 4, 2023 •
edited
Loading

Change in order of statement; Connection did release if there is an error in rollback or commit;

@sk222 sk222 requested review from dhmlau and raymondfeng as code owners July 4, 2023 04:37
@dhmlau
Copy link
Member

dhmlau commented Jul 8, 2023

@sk222, thanks for your contribution. Your change LGTM. Could you please sign the DCO? Thanks.
Here is the reference: https://loopback.io/doc/en/contrib/code-contrib.html.

@sk222
Release Connection on Error- Changing statement order
aac9884 
Signed-off-by: sk222 <skhanna428@gmail.com>
@sk222 sk222 force-pushed the connection-release-on-error branch from 02fd5d5 to aac9884 Compare July 15, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhmlau dhmlau Awaiting requested review from dhmlau dhmlau is a code owner

@raymondfeng raymondfeng Awaiting requested review from raymondfeng raymondfeng is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sk222 @dhmlau