Skip to content

Conversation

@lanlooker
Copy link
Contributor

@lanlooker lanlooker commented Oct 8, 2021

  • Rewrite README.me, include demo and environmental variable setup in Cloud Functions UI as gifs
  • Refactor main.py and test with 4 cases:
1. An email of a new user: {"email": "me@gmail.com"} passed
2. An email of an existing user: {"email": "me@gmail.com"} passed
3. Wrong input: Typo in key "email" --> {"emails": "me@gmail.com"} passed (throwing an exception) 
4. Wrong input: Value of key "email" being an empty string passed (throwing an exception) 

Tagging @josephaxisa since you reviewed the previous PR. Thank you for taking a look

@google-cla
Copy link

google-cla bot commented Oct 8, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 8, 2021
@google-cla
Copy link

google-cla bot commented Oct 8, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Oct 8, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@lanlooker lanlooker changed the title Cloud Functions Examples (User Provisioner) feat: Cloud Functions Examples (User Provisioner) Oct 8, 2021
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@josephaxisa josephaxisa self-requested a review October 12, 2021 08:32
Copy link
Contributor

@josephaxisa josephaxisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I left some suggestions :)

Comment on lines 24 to 29
if user_id is not None:
sdk.send_user_credentials_email_password_reset(user_id=user_id)
return 'A user with this email: {email} already existed; Password reset sent'.format(email=email)
elif user_id is None:
create_users(email=email)
return 'New user created; Setup/Welcome email sent to {email}'.format(email=email)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this can be changed to

Suggested change
if user_id is not None:
sdk.send_user_credentials_email_password_reset(user_id=user_id)
return 'A user with this email: {email} already existed; Password reset sent'.format(email=email)
elif user_id is None:
create_users(email=email)
return 'New user created; Setup/Welcome email sent to {email}'.format(email=email)
if user_id:
sdk.send_user_credentials_email_password_reset(user_id=user_id)
return 'A user with this email: {email} already existed; Password reset sent'.format(email=email)
else:
create_users(email=email)
return 'New user created; Setup/Welcome email sent to {email}'.format(email=email)

@josephaxisa josephaxisa self-requested a review October 13, 2021 08:38
Copy link
Contributor

@josephaxisa josephaxisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks like you need to accept the CLA though

@google-cla
Copy link

google-cla bot commented Oct 13, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Oct 19, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@lanlooker lanlooker removed the cla: no label Oct 19, 2021
@google-cla google-cla bot added cla: no and removed cla: yes labels Oct 24, 2021
@google-cla
Copy link

google-cla bot commented Oct 24, 2021

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants