✨ feat: support minimax as provider #2087

lwshen · 2024-04-18T11:46:20Z

💻 变更类型 | Change Type

🔀 变更说明 | Description of Change

Support model provider: Minimax

close #1053

minimax-demo.mp4

📝 补充信息 | Additional Information

vercel · 2024-04-18T11:46:24Z

@lwshen is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

lobehubbot · 2024-04-18T11:46:31Z

👍 @lwshen

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献，请确保您已经遵循了我们的贡献指南，我们会尽快审查它。
如果您遇到任何问题，请随时与我们联系。

arvinxx

感谢贡献！整体看下来没啥太大问题，个别自动生成的翻译需要调整下~

locales/nl-NL/modelProvider.json

locales/tr-TR/modelProvider.json

locales/zh-TW/modelProvider.json

codecov · 2024-04-18T12:10:11Z

Codecov Report

Attention: Patch coverage is 96.96970% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 92.62%. Comparing base (a3cb538) to head (a1e1c3d).
Report is 1 commits behind head on main.

Files	Patch %	Lines
src/libs/agent-runtime/minimax/index.ts	95.67%	8 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2087      +/-   ##
==========================================
+ Coverage   92.54%   92.62%   +0.07%     
==========================================
  Files         286      289       +3     
  Lines       16152    16416     +264     
  Branches     1868     1908      +40     
==========================================
+ Hits        14948    15205     +257     
- Misses       1204     1211       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vercel · 2024-04-18T13:55:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
lobe-chat-community	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 29, 2024 2:21am

arvinxx · 2024-04-18T14:20:29Z

@lwshen 我测了下 apikey 的余额不足的情况下，没有抛错：

这个是api接口本身就这样，没有返回错误码，还是实现问题？

lwshen · 2024-04-18T15:14:39Z

@lwshen 我测了下 apikey 的余额不足的情况下，没有抛错：
这个是api接口本身就这样，没有返回错误码，还是实现问题？

< HTTP/2 200
<
* Connection #0 to host api.minimax.chat left intact
{"base_resp":{"status_code":1004,"status_msg":"token is unusable"}}

试了一下 api key 失效的情况，api 依旧返回了 200 的状态码

arvinxx · 2024-04-19T01:42:52Z

这有点离谱… 有可能做兼容吗？

lobehubbot · 2024-04-19T01:43:02Z

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

This is a bit outrageous... Is it possible to do compatibility?

lwshen · 2024-04-19T07:43:46Z

这有点离谱… 有可能做兼容吗？

更新了一下代码。

本来打算直接从 openai response 中读取内容，但是 api 返回的不是 SSE 格式，读取不到里面的内容。

因此，实现了一个 MinimaxStream，通过返回值中的 status_code 进行判断有没有错误，不过遇到了 unhandledRejection 错误，不知道你有没有什么想法？

⨯ unhandledRejection: {
  error: { code: 1004, message: 'token is unusable' },
  errorType: 'InvalidMinimaxAPIKey',
  provider: 'minimax'
}

src/libs/agent-runtime/minimax/index.ts

arvinxx · 2024-04-20T09:58:11Z

@lwshen 得 rebase 下代码了，上一个 PR #2041 调整了 AgentRuntime 的位置

lobehubbot · 2024-04-20T09:58:24Z

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@lwshen needs to rebase the code. The previous PR #2041 adjusted the location of AgentRuntime.

lwshen · 2024-04-20T11:09:54Z

@lwshen 得 rebase 下代码了，上一个 PR #2041 调整了 AgentRuntime 的位置

done

lobehubbot · 2024-04-20T11:10:06Z

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@lwshen needs to rebase the code. The previous PR #2041 adjusted the location of AgentRuntime.

done

arvinxx · 2024-04-21T07:34:09Z

我试了下还是有问题

This reverts commit 4be6d67.

arvinxx

实现还是有点问题，流式输出没了，变成了一次性输出

src/libs/agent-runtime/minimax/index.ts

# Conflicts: # src/libs/agent-runtime/utils/openaiCompatibleFactory/index.ts

src/libs/agent-runtime/AgentRuntime.ts

src/libs/agent-runtime/minimax/index.ts

arvinxx · 2024-04-28T15:36:43Z

@lwshen rebase 下 main ，其他我测下来没问题了~

lobehubbot · 2024-04-28T15:36:53Z

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@lwshen rebase main and I have tested the others and everything is fine~

lwshen · 2024-04-28T15:45:13Z

@arvinxx done

arvinxx

LGTM now, I'll merge it. Thanks for your hard working! I'm really appraciate your great contribution! 👏

lobehubbot · 2024-04-29T02:58:01Z

❤️ Great PR @lwshen ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献，感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣，请加入我们的 discord，然后私信 @arvinxx 或 @canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发，分享和讨论全球范围内的 AI 消息。

## [Version 0.151.0](v0.150.10...v0.151.0) <sup>Released on **2024-04-29**</sup> #### ✨ Features - **misc**: Support minimax as a new provider. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Support minimax as a new provider, closes [#2087](#2087) ([00abd82](00abd82)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

lobehubbot · 2024-04-29T03:01:32Z

🎉 This PR is included in version 0.151.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [Version 1.31.0](v1.30.6...v1.31.0) <sup>Released on **2024-04-29**</sup> #### ✨ Features - **misc**: Support minimax as a new provider. #### 💄 Styles - **misc**: Improve Inbox Assistant Welcome Guide. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's improved * **misc**: Support minimax as a new provider, closes [lobehub#2087](https://github.com/bentwnghk/lobe-chat/issues/2087) ([00abd82](00abd82)) #### Styles * **misc**: Improve Inbox Assistant Welcome Guide, closes [lobehub#2086](https://github.com/bentwnghk/lobe-chat/issues/2086) ([df37212](df37212)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

* add minimax as provider * add i18n token * update * update * Revert "add i18n token" This reverts commit 4be6d67. * add i18n token * add doc * update i18n * implement MinimaxStream * use fetchSSE function * fix TypeError and SyntaxError * add unit test * add agent runtime * add debug log * use fetch function directly * refactor(minimax): streamline response parsing logic * remove redundant error response check * fix code style

arvinxx reviewed Apr 18, 2024

View reviewed changes

locales/nl-NL/modelProvider.json Outdated Show resolved Hide resolved

locales/tr-TR/modelProvider.json Outdated Show resolved Hide resolved

locales/zh-TW/modelProvider.json Outdated Show resolved Hide resolved

vercel bot deployed to Preview April 18, 2024 14:02 View deployment

arvinxx reviewed Apr 19, 2024

View reviewed changes

src/libs/agent-runtime/minimax/index.ts Outdated Show resolved Hide resolved

lwshen force-pushed the minimax branch from 21f90f2 to 5d44592 Compare April 19, 2024 17:13

lwshen force-pushed the minimax branch from 5d44592 to 2bde6dd Compare April 20, 2024 10:42

vercel bot deployed to Preview April 20, 2024 15:59 View deployment

lwshen force-pushed the minimax branch 4 times, most recently from 8b2530e to 7a954b3 Compare April 21, 2024 14:41

lwshen added 6 commits April 21, 2024 22:47

add minimax as provider

30737b7

add i18n token

adca20e

update

a94a9a6

update

e787a87

Revert "add i18n token"

47ec224

This reverts commit 4be6d67.

add i18n token

2cbaf22

arvinxx requested changes Apr 25, 2024

View reviewed changes

src/libs/agent-runtime/minimax/index.ts Outdated Show resolved Hide resolved

lwshen added 5 commits April 25, 2024 18:24

refactor(minimax): streamline response parsing logic

0e8549b

Merge branch 'main' into minimax

602a2af

Merge branch 'refs/heads/main' into minimax

39a52d6

# Conflicts: # src/libs/agent-runtime/utils/openaiCompatibleFactory/index.ts

remove redundant error response check

8269ad8

Merge branch 'refs/heads/main' into minimax

ee7064a

lwshen requested a review from arvinxx April 28, 2024 02:22

Merge branch 'main' into minimax

de21b03

arvinxx reviewed Apr 28, 2024

View reviewed changes

src/libs/agent-runtime/AgentRuntime.ts Outdated Show resolved Hide resolved

src/libs/agent-runtime/minimax/index.ts Show resolved Hide resolved

arvinxx changed the title ~~feat: support minimax as provider~~ ✨ feat: support minimax as provider Apr 28, 2024

fix code style

6423174

lwshen requested a review from arvinxx April 28, 2024 03:33

vercel bot deployed to Preview April 28, 2024 15:22 View deployment

Merge branch 'refs/heads/main' into minimax

a1e1c3d

vercel bot deployed to Preview April 29, 2024 02:21 View deployment

arvinxx approved these changes Apr 29, 2024

View reviewed changes

arvinxx merged commit 00abd82 into lobehub:main Apr 29, 2024
6 checks passed

lobehubbot added the released label Apr 29, 2024

ifsheldon mentioned this pull request Apr 29, 2024

[Request] Add MiniMax new models #2280

Closed

lwshen deleted the minimax branch April 29, 2024 07:59

arvinxx mentioned this pull request May 6, 2024

[Request] Function calling support for minimax models #2394

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ feat: support minimax as provider #2087

✨ feat: support minimax as provider #2087

lwshen commented Apr 18, 2024 •

edited by arvinxx

vercel bot commented Apr 18, 2024

lobehubbot commented Apr 18, 2024

arvinxx left a comment

codecov bot commented Apr 18, 2024 •

edited

vercel bot commented Apr 18, 2024 •

edited

arvinxx commented Apr 18, 2024

lwshen commented Apr 18, 2024

arvinxx commented Apr 19, 2024

lobehubbot commented Apr 19, 2024

lwshen commented Apr 19, 2024

arvinxx commented Apr 20, 2024

lobehubbot commented Apr 20, 2024

lwshen commented Apr 20, 2024

lobehubbot commented Apr 20, 2024

arvinxx commented Apr 21, 2024

arvinxx left a comment

arvinxx commented Apr 28, 2024

lobehubbot commented Apr 28, 2024

lwshen commented Apr 28, 2024

arvinxx left a comment •

edited

lobehubbot commented Apr 29, 2024

lobehubbot commented Apr 29, 2024

✨ feat: support minimax as provider #2087

✨ feat: support minimax as provider #2087

Conversation

lwshen commented Apr 18, 2024 • edited by arvinxx

💻 变更类型 | Change Type

🔀 变更说明 | Description of Change

📝 补充信息 | Additional Information

vercel bot commented Apr 18, 2024

lobehubbot commented Apr 18, 2024

arvinxx left a comment

Choose a reason for hiding this comment

codecov bot commented Apr 18, 2024 • edited

Codecov Report

vercel bot commented Apr 18, 2024 • edited

arvinxx commented Apr 18, 2024

lwshen commented Apr 18, 2024

arvinxx commented Apr 19, 2024

lobehubbot commented Apr 19, 2024

lwshen commented Apr 19, 2024

arvinxx commented Apr 20, 2024

lobehubbot commented Apr 20, 2024

lwshen commented Apr 20, 2024

lobehubbot commented Apr 20, 2024

arvinxx commented Apr 21, 2024

arvinxx left a comment

Choose a reason for hiding this comment

arvinxx commented Apr 28, 2024

lobehubbot commented Apr 28, 2024

lwshen commented Apr 28, 2024

arvinxx left a comment • edited

Choose a reason for hiding this comment

lobehubbot commented Apr 29, 2024

lobehubbot commented Apr 29, 2024

lwshen commented Apr 18, 2024 •

edited by arvinxx

codecov bot commented Apr 18, 2024 •

edited

vercel bot commented Apr 18, 2024 •

edited

arvinxx left a comment •

edited