Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Function calling support for minimax models #2394

Closed
ifsheldon opened this issue May 6, 2024 · 6 comments · Fixed by #2414
Closed

[Request] Function calling support for minimax models #2394

ifsheldon opened this issue May 6, 2024 · 6 comments · Fixed by #2414
Labels
🌠 Feature Request New feature or request | 特性与建议 released

Comments

@ifsheldon
Copy link

🥰 Feature Description

Please add function calling/plugin calling for minimax models. Now plugins are disabled when a minimax model is selected. But MiniMax models and APIs support function calling. If the code calls MiniMax ChatCompletionV2 APIs, then adding function calling should be easy since the APIs are compatible with OpenAI's APIs.

🧐 Proposed Solution

Add function calling support for MiniMax models by copying and modifying the function calling support for OpenAI's models.

📝 Additional Information

No response

@ifsheldon ifsheldon added the 🌠 Feature Request New feature or request | 特性与建议 label May 6, 2024
@lobehubbot
Copy link
Member

👀 @ifsheldon

Thank you for raising an issue. We will investigate into the matter and get back to you as soon as possible.
Please make sure you have given us as much context as possible.
非常感谢您提交 issue。我们会尽快调查此事,并尽快回复您。 请确保您已经提供了尽可能多的背景信息。

@ifsheldon
Copy link
Author

I tried to investigate into this and found a minor discrepancy that is not compatible with OpenAI's API. The parameters of a function should be a string, not a json object. Otherwise, MiniMax will throw an error. That means, we need to serialize the object describing the parameters of a function into a string first and then serialize the ChatStreamPayload object.

@arvinxx
Copy link
Contributor

arvinxx commented May 6, 2024

@ifsheldon I have tried it. there is a really challange due to we pasre the response by ourself due to Minimax's strange error code. #2087 (comment)

I'll consider it in the #1310

@lobehubbot
Copy link
Member

@ifsheldon

This issue is closed, If you have any questions, you can comment and reply.
此问题已经关闭。如果您有任何问题,可以留言并回复。

@lobehubbot
Copy link
Member

🎉 This issue has been resolved in version 0.157.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ifsheldon
Copy link
Author

@arvinxx Wow, the progress you've made are just unbelievable. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌠 Feature Request New feature or request | 特性与建议 released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@arvinxx @ifsheldon @lobehubbot and others