Make sourcemap generation a bit faster #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This basically memoizes the split() call. That way, we split the lines once per file instead of on every mapping. And it provides a class to add future memoization. |
|
hi, is this pull-request OK? |
|
Looks good to me (and a PR from Medium has some clout ;). Pulling. Thanks! |
matthew-dean
added a commit
that referenced
this pull request
Mar 15, 2016
Make sourcemap generation a bit faster
This was referenced May 8, 2016
Closed
|
Note that this PR needed to be reverted. You're welcome to open a new PR, but because the first PR passed Less tests, you would need to add tests demonstrating the first PR failing, and the second PR succeeding. See: #2896 |
|
Might want to reopen #2828? 😉 |
|
@frostyfrog Good catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #2828